Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial action implemention #1

Merged
merged 78 commits into from
Oct 10, 2024
Merged

Initial action implemention #1

merged 78 commits into from
Oct 10, 2024

Conversation

omus
Copy link
Member

@omus omus commented Aug 12, 2024

Implements a working solution for capturing output from all jobs in a matrix. See https://github.com/orgs/community/discussions/26639 for general discussion on this GitHub issue.

See the design.md file for details on the implementation details and design decisions behind this action.

Depends on:

@omus
Copy link
Member Author

omus commented Aug 13, 2024

I noticed if you re-run a job you can end up finding more artifacts than the strategy.job-total. This detection scenario seems flawed in that multiple re-runs could result in us falsely believing all the jobs had completed when in fact we may have not successfully run one of the jobs. I've now dropped the artifact count logic.

https://github.com/beacon-biosignals/matrix-output/actions/runs/10376312018/job/28728003750#step:3:54

@omus
Copy link
Member Author

omus commented Aug 13, 2024

Looks like I got a natural race condition on "Setup Complex" https://github.com/beacon-biosignals/matrix-output/actions/runs/10376653588/job/28729096768?pr=1 just after I added the artificial race condition test.

@omus
Copy link
Member Author

omus commented Aug 13, 2024

Checkout is causing me grief now:

Error: Repository path '/home/runner/work/_actions/beacon-biosignals/matrix-output/466c693173d9d5b623e6125d66afb817477e5a83/job-context/repo' is not under '/home/runner/work/matrix-output/matrix-output'

https://github.com/beacon-biosignals/matrix-output/actions/runs/10377452845/job/28731668322?pr=1

@omus
Copy link
Member Author

omus commented Aug 16, 2024

Just fixed a bug where when two jobs wait for each other they weren't finding their sync artifacts due to comparing a numeric value with string in jq: https://github.com/beacon-biosignals/matrix-output/actions/runs/10414887856/job/28844541439?pr=1

I'm rather glad I hit this minor bug has it demonstrated that is possible for two jobs to have a complete set of outputs. Previously, this was just a theoretical problem.

@omus omus requested a review from kleinschmidt August 16, 2024 16:20
@omus omus requested review from MKVatinyan and removed request for kleinschmidt October 10, 2024 16:13
@omus omus merged commit db3dbfa into main Oct 10, 2024
13 checks passed
@omus omus deleted the cv/initial branch October 10, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants