Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beam 3317 - use proper embed process #1993

Merged
merged 2 commits into from
Dec 19, 2022
Merged

beam 3317 - use proper embed process #1993

merged 2 commits into from
Dec 19, 2022

Conversation

cdhanna
Copy link
Collaborator

@cdhanna cdhanna commented Dec 14, 2022

Ticket

https://disruptorbeam.atlassian.net/browse/BEAM-3317

Brief Description

We got a whacky exception from embed io, and looking at their github page, I found this
unosquare/embedio#570

And the critical part is...

use of HttpContext.SendDataAsync(), which must never be called from a WebApiModule.

But we do that... Sooooo, maybe we should not. So this PR changes the structure to follow their documentation described here
https://unosquare.github.io/embedio/wiki/Cookbook.html#example-of-a-get-request

Checklist

Notes

When you are merging a feature branch into main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging from main to staging, or staging to production, please use a regular merge commit.

@github-actions
Copy link
Contributor

Have a WebGL build, friend. c2738b84fe75794271eeff663375471249e350e1

Copy link
Collaborator

@Leinnan Leinnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐗

@cdhanna cdhanna merged commit 060da04 into main Dec 19, 2022
@cdhanna cdhanna deleted the feature/beam-3317 branch December 19, 2022 14:17
@github-actions
Copy link
Contributor

Have a WebGL build, friend. dceeec69c0af4ffab7a43540dee10898a0be9856

Leinnan pushed a commit that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants