beam 3317 - use proper embed process #1993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://disruptorbeam.atlassian.net/browse/BEAM-3317
Brief Description
We got a whacky exception from embed io, and looking at their github page, I found this
unosquare/embedio#570
And the critical part is...
But we do that... Sooooo, maybe we should not. So this PR changes the structure to follow their documentation described here
https://unosquare.github.io/embedio/wiki/Cookbook.html#example-of-a-get-request
Checklist
/wiki/BEAM-1234.md
? You need to provide a docs file.Notes
When you are merging a feature branch into
main
, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging frommain
tostaging
, orstaging
toproduction
, please use a regular merge commit.