169L Email Updates + Ruby 3 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cycomachead
commented
Jun 23, 2023
•
cycomachead
commented
- most of the work for email templates
- TODO: actually selecting/using new email templates
- TODO: using the pending state for teachers/request more info
- updates to ruby 3.2
- fixes microsoft omniauth
- adds more sentry logging to omniauth
- a bunch of test refactoring / dependency updates
Email template
…9/main * 'main' of github.com:cs169/BJC-Teacher-Tracker: changed tests rubocop passing Matthew Chuang
* main: Update ruby version, fix the migrations script Move google analytics to the footer, since some pages have different layout
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage ? 82.28%
=======================================
Files ? 21
Lines ? 621
Branches ? 0
=======================================
Hits ? 511
Misses ? 110
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.