Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template. #370

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Conversation

carreter
Copy link
Collaborator

@carreter carreter commented Sep 23, 2023

Changes in this PR

Add a PR template. This PR itself uses this template to give everyone an idea of what the template is like.

Why are you making these changes?

A PR template will make it easier to track what changes are made and ensure new changes satisfy all documentation and testing requirements. Part of #346 .

Are any changes breaking? (IMPORTANT)

This is a devops/documentation change, so no.

Pre-merge checklist

All of these must be satisfied before this PR is considered ready for merging. Mergeable PRs will be prioritized for review.

  • New packages/exported functions have docstrings.
  • New/changed functionality is thoroughly tested.
  • New/changed functionality has a function giving an example of its usage in the associated test file. See primers/primers_test.go for what this might look like.
  • Changes are documented in CHANGELOG.md in the [Unreleased] section.
  • All code is properly formatted and linted.
  • The PR template is filled out.

@TimothyStiles TimothyStiles merged commit b29c5ff into bebop:main Sep 23, 2023
6 checks passed
@carreter carreter deleted the pr-template branch September 26, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants