Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCR bug (issue #279). #378

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

carreter
Copy link
Collaborator

Changes in this PR

In generatePcrFragments(), there was a loop that was erroneously iterating over the indices of forwardPrimerIndxs rather than the values of the slice itself.

Why are you making these changes?

Fixes #279 .

Are any changes breaking? (IMPORTANT)

No.

Pre-merge checklist

All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.

  • New packages/exported functions have docstrings.
  • New/changed functionality is thoroughly tested.
  • New/changed functionality has a function giving an example of its usage in the associated test file. See primers/primers_test.go for what this might look like.
  • Changes are documented in CHANGELOG.md in the [Unreleased] section.
  • All code is properly formatted and linted.
  • The PR template is filled out.

@TimothyStiles TimothyStiles merged commit 41a9515 into bebop:main Sep 26, 2023
4 checks passed
@carreter carreter deleted the pcr-simulation-bug branch September 26, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCR simulations are wrong.
2 participants