-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AWS CDK project and Helm charts for Beckn-Onix deployment o… #233
feat: Add AWS CDK project and Helm charts for Beckn-Onix deployment o… #233
Conversation
Moz had covered most of the architectural and high level deployment model in his tech talks on this. It all seemed fine. All the code is in a separate folder. I have not understood the code, but I am guessing the risk in merging is small. So I am approving it. I have requested @prasad-takale-eminds for a review if his time permits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mozammil89 Please find the below review comment
-
In
aws-cdk/beckn-cdk/cdk.context.json
, the Availability Zone and Account ID are hard-coded. Please make these configurable. -
Kindly include a sample
.env
file. -
In
aws-cdk/beckn-cdk/lib/config.ts
, the.env
file is missing from theaws-cdk/beckn-cdk
directory. The linedotenv.config({ path: path.resolve(__dirname, "../.env") });
expects it to be present. -
The RDS password is being saved in AWS Secrets Manager. We need to disable secret rotation for the RDS password since we are updating the config files during the initial installation.
-
Ensure the Layer2 configuration setup is installed after the BAP and BPP deployment.
-
Regarding the pull policy set as
IfNotPresent
, how should we update to a new version of the application?
Thank you for the review, @vbabuEM and @prasad-takale-eminds. Below are my responses to the comments:
|
@mozammil89 For Layer2 if the user wants to install domain-specific layer2 config then how we can install that? |
@prasad-takale-eminds The approach you need to take in Kubernetes environment is fairly straightforward. You simply mount the EFS shared volume (used for BAP or BPP) onto an EC2 machine (any micro VM could help) and copy the Layer 2 configuration file. The new files will immediately become available to the corresponding pods. Mounting an EFS file system is an easy process:
$ mkdir efs
$ sudo mount -t efs file-system-id efs/
I'll update the readme with above steps. Let me know if you're OK with it. Cc: @vbabuEM |
Sure, this will help. |
…n AWS cloud
Any many more...