Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor js implementation #65

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

mayurvir
Copy link
Contributor

@mayurvir mayurvir commented Apr 7, 2024

Description

This PR will add an API to create categories.

Features covered

<Put the link of your Jira task. Should be ideally 1 but if in case there are more than one, you should add all of them.>

Changes made

* Added a new controller for categories * Added aws-s3 library for downloading images * Added test cases for apis * Updated API documentation * spelling correction in the helper function

Screenshots/recordings

<If possible, create a screen recording or add screenshots of changes you have made. This will allow the reviewer to test the pr quickly and not miss anything due to assumptions>

Testing

Self checks

  • Code follows coding style guidelines.
  • All tests pass successfully.
  • No new linting errors or warnings.
  • Documentation is updated, if necessary.
  • Dependencies are updated, if required.
  • There are no merge conflicts.

Reviewer Suggestions

<Any suggestions that you want the reviewer to look at such as special instructions, any files that you want them to specially check.>

@mayurvir mayurvir marked this pull request as draft April 7, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant