Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:typo import objc_property #530

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

pome-ta
Copy link
Contributor

@pome-ta pome-ta commented Oct 16, 2024

I am thrilled every time I use it and I love it. Thank you!

There were parts of the tutorial in the documentation that I felt were unnecessary.

This is the first time I have sent a PR. I would appreciate it if you could let me know if there are any other procedures I need to follow.

from rubicon.objc import NSObject, objc_method, objc_property()

Import brackets were deemed unnecessary and removed.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the kind words, and the fix!

As for procedures around contributing - the only thing you'll be missing is a change note. We automatically generate our release notes from files committed as part of each PR; in this case, you need to add a file named changes/530.misc.rst that describes the change - something like A typo in the tutorial was corrected..

@qqfunc
Copy link
Contributor

qqfunc commented Oct 16, 2024

See this guide for help.

@pome-ta
Copy link
Contributor Author

pome-ta commented Oct 16, 2024

@freakboy3742
Thank you for the specific explanation.
I had missed an important procedure.

Also, thank you for your quick response.

(I don't have much knowledge, so when I pushed the file, I was surprised that CI started running 😂)

@pome-ta
Copy link
Contributor Author

pome-ta commented Oct 16, 2024

@qqfunc

Thank you for always supporting me by providing information on my oversights 😍

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix!

@freakboy3742 freakboy3742 merged commit e186ab5 into beeware:main Oct 16, 2024
20 checks passed
@pome-ta pome-ta deleted the hotfix-typo/tutorial-2.rst branch October 17, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants