fix:add already local service check to avoid panic

begonia-org · Jun 1, 2024 · db00cd9 · db00cd9
1 parent 1c000e8
commit db00cd9
Show file tree

Hide file tree

Showing 3 changed files with 309 additions and 295 deletions.
diff --git a/gateway/gateway.go b/gateway/gateway.go
@@ -90,6 +90,10 @@ func (g *GatewayServer) RegisterService(ctx context.Context, pd ProtobufDescript
 	return g.httpGateway.RegisterHandlerClient(ctx, pd, g.gatewayMux)
 }
 func (g *GatewayServer) RegisterLocalService(ctx context.Context, pd ProtobufDescription, sd *grpc.ServiceDesc, ss any) error {
+	info:=g.grpcServer.GetServiceInfo()
+	if _,ok:=info[sd.ServiceName];ok{
+		return fmt.Errorf("service %s already exists",sd.ServiceName)
+	}
 	g.grpcServer.RegisterService(sd, ss)
 	return g.httpGateway.RegisterHandlerClient(ctx, pd, g.gatewayMux)
 }

diff --git a/gateway/http_test.go b/gateway/http_test.go
@@ -567,6 +567,10 @@ func testRegisterLocalService(t *testing.T) {
 		c.So(rsp.Message, c.ShouldEqual, "hello")
 		c.So(rsp.Name, c.ShouldEqual, "world")
 
+		err = localGW.RegisterLocalService(context.Background(), pd, exampleServer.Desc(), exampleServer)
+		c.So(err, c.ShouldNotBeNil)
+		c.So(err.Error(), c.ShouldContainSubstring, "already exists")
+
 	})
 	c.Convey("test del local service", t, func() {
 		localGW.DeleteLocalService(pd)