fixup! OSSL_PROVIDER_load_ex

beldmit · Aug 3, 2023 · dc6d970 · dc6d970
1 parent 3514ee7
commit dc6d970
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/crypto/provider_core.c b/crypto/provider_core.c
@@ -569,15 +569,19 @@ OSSL_PROVIDER *ossl_provider_new_ex(OSSL_LIB_CTX *libctx, const char *name,
         for (i = 0; params[i].key != NULL; i++) {
             if (params[i].data_type != OSSL_PARAM_UTF8_STRING)
                 continue;
-            if (ossl_provider_info_add_parameter(&template, params[i].key, 
+            if (ossl_provider_info_add_parameter(&template, params[i].key,
                                                  (char *)params[i].data) <= 0)
                 return NULL;
         }
     }
 
     /* provider_new() generates an error, so no need here */
-    if ((prov = provider_new(name, template.init, template.parameters)) == NULL)
+    if ((prov = provider_new(name, template.init, template.parameters)) == NULL) {
+        sk_INFOPAIR_pop_free(template.parameters, infopair_free);
         return NULL;
+    }
+    /* Parameters are copied, let's free them */
+    sk_INFOPAIR_pop_free(template.parameters, infopair_free);
 
     prov->libctx = libctx;
 #ifndef FIPS_MODULE