Add fluent problem properties #132
Conversation
| @Test | ||
| void fluentProperties() { | ||
| InputValidationProblem problem = new MyInputValidationProblem() | ||
| .detail("detail message") |
There was a problem hiding this comment.
If we don't override the fluent setters in InputValidationProblem, this chaining wouldn't work.
You would need to reverse the order to
InputValidationProblem problem = new MyInputValidationProblem()
.issues(InputValidationIssues.requiredInput(InEnum.QUERY, "test"))
.detail("detail message");The self-referencing generics trick we used in https://github.com/belgif/rest-problem-java/pull/101/files cannot be applied here, because an exception class cannot be generic.
There was a problem hiding this comment.
I've played around with the implementation but wasn't able to find an alternative approach. Even looked at the manifold compiler plugin which Pieter often mentions but even its crazy change features don't seem to often anything we can use here.
Simply a limitation of the language.
There was a problem hiding this comment.
I tried out another approach with interfaces and default methods to reduce the boilerplate.
One drawback is that an explicit implements Fluent*Problem<SELF> is required on all concrete problem classes that wish to have these fluent properties. Whereas in the previous approach the fluent properties would automatically be inherited from the super class (but with the "wrong" return type, requiring to override to allow proper method chaining).
What do you think @belgif/rest-problem-java?
There was a problem hiding this comment.
If it does the trick, it's good for me. Adding more children with new properties to the hierarchy will make it more complex but I don't think we are going into that direction.
|
|
No description provided.