Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menambah reduce pada manipulasi array dan menghapus 1 kata pada doc strictmode #110

Merged
merged 6 commits into from
Oct 9, 2021

Conversation

doniyukri
Copy link
Contributor

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya memperbaiki dokumentasi
  • saya menambah dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = windows

Testing

  • doctesting js
  • lint testing eslint

Maintainer

@auto-add-label auto-add-label bot added the enhancement New feature or request label Oct 8, 2021
Copy link
Contributor

@mzaini30 mzaini30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perbaikan Ejaan Bahasa Indonesia (EBI).

basic/010_array_manipulation/README.md Outdated Show resolved Hide resolved
basic/010_array_manipulation/README.md Outdated Show resolved Hide resolved
@doniyukri
Copy link
Contributor Author

Oke sudah diperbaiki, makasih

@nomadkode nomadkode requested review from a team October 9, 2021 01:48
Copy link
Contributor

@nomadkode nomadkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seharusnya dokumentasi sudah aman. LGTM 🚀

Terima kasih @doniyukri sudah berkontribusi pada repo Javascript di Bellshade. 👍🏻

@reacto11mecha reacto11mecha requested review from mzaini30 and a team October 9, 2021 12:24
@reacto11mecha
Copy link
Member

Mungkin ini cara ngefixnya tinggal disamain HEAD nya di repo fork branch saat ini yang mas saat ini PR.
Lengkapnya baca #58.

git fetch upstream main
git pull upstream main
git push

@reacto11mecha reacto11mecha merged commit a9ddf21 into bellshade:main Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants