-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for getting projected coordinates #23
Draft
jorisvandenbossche
wants to merge
1
commit into
benbovy:main
Choose a base branch
from
jorisvandenbossche:projected-coords
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
#include <stdexcept> | ||
#include <iostream> | ||
|
||
#include <s2/s2projections.h> | ||
#include <s2/s2latlng.h> | ||
#include <s2geography.h> | ||
|
||
#include "geography.hpp" | ||
#include "pybind11.hpp" | ||
|
||
namespace py = pybind11; | ||
namespace s2geog = s2geography; | ||
using namespace spherely; | ||
|
||
|
||
std::tuple<double, double> project_mercator(py::object obj) { | ||
auto geog = (static_cast<PyObjectGeography&>(obj)).as_geog_ptr(); | ||
if (geog->geog_type() != GeographyType::Point) { | ||
throw py::value_error("test"); | ||
} | ||
auto point = static_cast<Point*>(geog); | ||
auto s2point = point->s2point(); | ||
|
||
auto projection = S2::MercatorProjection(20037508.3427892); | ||
auto r2point = projection.Project(s2point); | ||
double x = r2point.x(); | ||
double y = r2point.y(); | ||
|
||
return std::make_tuple(x, y); | ||
} | ||
|
||
|
||
void init_projections(py::module& m) { | ||
// m.def("intersects", py::vectorize(&intersects), py::arg("a"), py::arg("b"), | ||
// R"pbdoc( | ||
// Returns True if A and B share any portion of space. | ||
|
||
// Intersects implies that overlaps, touches and within are True. | ||
|
||
// Parameters | ||
// ---------- | ||
// a, b : :py:class:`Geography` or array_like | ||
// Geography object(s) | ||
|
||
// )pbdoc"); | ||
|
||
m.def("project_mercator", &project_mercator); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem with vectorizing a function like this is that it returns multiple values for each input value (so in numpy ufunc terms, it would be a generalize ufunc with a signature of "()->(n)" (adding one dimension)). But this is not something that
py::vectorize
supports AFAIK. So we might need to write this more manually (eg writing the loop ourselves, only supporting 1D input, which is what we do in shapely as well).And for non-point geographies, it doesn't fit in the ufunc paradigm anyway, since you have a variable number of coordinate pairs that gets returned (like
shapely.get_coordinates
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we follow
shapely.get_coordinates
API then? I.e., return a (N, 2) array with a flat index. I guess with tessellation enabled we'll almost always want to get the index.