CI release: activate windows builds #45
Conversation
For some reason GNU (mingw) compilers are used to compile s2geography, and s2geography's cmake script only adds math defines for s2geometry transitive headers if msvc is used.
This hopefully fixes s2geography main header file not found when building spherely windows wheels.
|
Yes finally wheels on Windows! @jorisvandenbossche perhaps you may want to have a look here? There is still room for improving the way we build python wheels here, e.g.,
This can be done later, though (I already spent a lot of time on packaging). |
|
Great! Agreed that if it is working, this is more than good enough for now, and we can see to streamline the setup more in the future.
With pyogrio I have a good experience with using vcpkg for all platforms, so I would prefer that as well. Especially seeing the hoops you had to go through to get all dependencies properly installed in the end in #35, I was already wondering if vcpkg wouldn't make that easier (but that is not a given, of course .. ;)) One annoyance with the vcpkg setup is of course that s2geography is not included and so requires to still have some custom install script anyway. I don't know how easy it is to add a package to vcpkg upstream, but we could also have a local "overlay port" (https://learn.microsoft.com/en-us/vcpkg/concepts/overlay-ports), which might simplify to integrate s2geography in a full vcpkg workflow. But all ideas for later ;) |
|
Can you push a dummy change to one of the relevant files to check if the caching works? |
|
Caching seems to work well. |
|
Thanks Joris! |
No description provided.