Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom dotenv path #1183

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

tE3m
Copy link
Contributor

@tE3m tE3m commented Oct 7, 2024

Recently, I installed the project via pipx in combination with a dotenv file for the config as a systemd service. However, the default (and hardcoded) location of the dotenv is the parent directory of the app, which makes sense if the app sits in the repo's directory. When installing with pipx though, one would need to put the dotenv file into the site-packages directory which doesn't seem sensible, even if harmless. As such, I thought it would make sense to allow setting a custom path to the dotenv (something like ~/.config/whoogle/whoogle.env), which this change allows by passing .env's path to the environment variable WHOOGLE_DOTENV_PATH while defaulting to the current behavior

Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@benbusby benbusby merged commit c54f4a7 into benbusby:main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants