Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when actual list zero lists, the apk should alwasy return 1.0; #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apmfifty
Copy link

@apmfifty apmfifty commented Jun 3, 2018

  1. when actual list zero lists, the apk should alwasy return 1.0; The current versio of code will always return 0.0 which is different from the code of function using pip install.
  2. Besides, put the code at first to skip unncessary operation.

…rrent versio of code will always return 0.0 which is different from the code of function using pip install. Besides, put the code at first to skip unncessary operation.
@codelucas
Copy link

I thought the right way to do it was if the actual list was length 1 we should not include the ndcg because that value will always be 1. The result is, if you have a lot of 1 sized lists your metric will be skewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants