Test on Python 3.11 #143
Closed
Test on Python 3.11 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benhoyt https://github.com/benhoyt/scandir/actions/runs/5993519451/job/16254028700 seems falling back to python implementation. Maybe a setup.py flag to fail if C-ext compilation fails is preffered. |
|
Oh, good spotting, thanks! For now I think I'll just merge #142 (which now includes these changes). I think we had a reason for making build not fail in that case (way back when), so I'd rather not risk breaking that workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see if tests fail on Python 3.11 Windows due to #141.