test: also confirm str(exc) for invalid requests

benoitc · Jul 4, 2024 · 1289239 · 1289239
1 parent dd4495f
commit 1289239
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/tests/requests/invalid/version_03.http b/tests/requests/invalid/version_03.http
@@ -0,0 +1,2 @@
+GET /foo HTTP/0.9\r\n
+\r\n
diff --git a/tests/requests/invalid/version_03.py b/tests/requests/invalid/version_03.py
@@ -0,0 +1,2 @@
+from gunicorn.http.errors import InvalidHTTPVersion
+request = InvalidHTTPVersion
diff --git a/tests/test_invalid_requests.py b/tests/test_invalid_requests.py
@@ -23,5 +23,6 @@ def test_http_parser(fname):
     cfg = env["cfg"]
     req = treq.badrequest(fname)
 
-    with pytest.raises(expect):
+    # telling pytest to match the exception string validates its __str__()
+    with pytest.raises(expect, match="."):
         req.check(cfg)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		from gunicorn.http.errors import InvalidHTTPVersion
		request = InvalidHTTPVersion