Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the bento size to include the size of models #4226

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming [email protected]

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming frostming requested a review from a team as a code owner October 10, 2023 01:52
@frostming frostming requested review from aarnphm and removed request for a team October 10, 2023 01:52
@sauyon
Copy link
Contributor

sauyon commented Oct 10, 2023

Should we change the list output to show a separate bento size and model size?

aarnphm
aarnphm previously approved these changes Oct 10, 2023
@frostming
Copy link
Contributor Author

Should we change the list output to show a separate bento size and model size?

Sounds good. Updated

@aarnphm aarnphm merged commit cefef4d into bentoml:main Oct 12, 2023
40 of 42 checks passed
@aarnphm aarnphm mentioned this pull request Oct 12, 2023
5 tasks
@frostming frostming deleted the fix/bento-size branch October 17, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants