-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import model for transformers framework #4247
feat: import model for transformers framework #4247
Conversation
I think I propose we should accept the following bentoml models import https://huggingface.co/meta-llama/Llama-2-7b-chat-hf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @larme for another look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aarnphm could you take a look of the revised codes and maybe approve the changes? Our status is:
|
Co-authored-by: Frost Ming <mianghong@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets get this in
What does this PR address?
Add import model method to transformers framework allowing users to directly download models from huggingface to bentoml model store. Add additional functionality to
bentoml models import
to import from huggingface. (eg.bentoml models import hf:t5-base
)Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.