Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clean up examples folder #5154

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

Sherlock113
Copy link
Contributor

@Sherlock113 Sherlock113 commented Dec 26, 2024

What does this PR address?

Remove projects from the examples folder. This page https://docs.bentoml.com/en/latest/examples/overview.html will be the single source of truth to maintain the list of example projects going forward.

Before submitting:

Signed-off-by: Sherlock113 <[email protected]>
@Sherlock113 Sherlock113 requested a review from a team as a code owner December 26, 2024 02:25
@Sherlock113 Sherlock113 requested review from ssheng and removed request for a team December 26, 2024 02:25
@Sherlock113 Sherlock113 self-assigned this Dec 26, 2024
@Sherlock113 Sherlock113 added the documentation Documentation, tutorials, and example projects label Dec 26, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • MLflow
  • XGBoost

@Sherlock113
Copy link
Contributor Author

Seems like some CI tasks failed because of the projects removed.

@bojiang @frostming Please use other folders/projects for CI tasks. You can clone the projects elsewhere and run tests with them. The examples folder will be cleaned up. Thanks.

@frostming
Copy link
Contributor

Seems like some CI tasks failed because of the projects removed.

@bojiang @frostming Please use other folders/projects for CI tasks. You can clone the projects elsewhere and run tests with them. The examples folder will be cleaned up. Thanks.

I've moved the project into test fixtures directory, thanks

@Sherlock113 Sherlock113 merged commit eaf5f7e into bentoml:main Dec 26, 2024
52 of 53 checks passed
@Sherlock113 Sherlock113 deleted the docs/example-cleanup branch December 26, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, tutorials, and example projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants