This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bentoctl version 0.4.0 is bugged as raised in two issues recently :
This is due to the context manager not being passed to the operator somehow, so the temporary file system is not found :
bentoctl/bentoctl/deployment_config.py
Lines 247 to 257 in 3c1e08c
Going back to version 0.3.4 does not work as the models are not copied at all in the bento before deployment on EC2 using kubectl.
As a quick fix I propose to replace the context manager by a permanent copy of models in the bento that will be deployed.