Add DEFAULT_MAXLIFE_VALUE and DEFAULT_MAXLIFE_UNIT config params #322
Conversation
| value_default = current_app.config['DEFAULT_MAXLIFE_VALUE'] | ||
| if value_default == None: | ||
| value_default = 'MONTHS' | ||
| value_default = '1' |
There was a problem hiding this comment.
| value_default = current_app.config['DEFAULT_MAXLIFE_VALUE'] | |
| if value_default == None: | |
| value_default = 'MONTHS' | |
| value_default = '1' | |
| value_default = current_app.config.get('DEFAULT_MAXLIFE_VALUE', '1') |
There was a problem hiding this comment.
Looks much nicer - but the values from bepasty.conf do not get picked up in the web UI.
I'm testing with https://hub.docker.com/r/asmaps/bepasty, editing the code in /usr/local/lib/python3.9/site-packages/bepasty/ if that makes a difference.
Does templates/index.html need some modification, maybe? <select class="form-control" name="maxlife-unit" size="1"> seems to always pick the first option, which is "Months"...
There was a problem hiding this comment.
Oh, yes, guess it needs to generate different html, making this a bit more complicated...
There was a problem hiding this comment.
And that's where my experience ends, unfortunately. Hopefully someone else can chime in.
I'll probably edit index.html in a custom docker image for now...
There was a problem hiding this comment.
Thinking about whether we could just have a fixed unit (e.g. days) and maybe allow a float value also.
That would be much easier overall, but also require a bigger change in the code and templates. Also, one would need to check the documented api and client code, whether we can do such a change without breaking existing clients.
There was a problem hiding this comment.
Note:
https://github.com/bepasty/bepasty-client-cli that client uses the existing unit/value web api.
This hopefully may fix #282
Not a python developer myself, yet gave it a shot. Please forgive my ignorance, but I really need this...