Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CometBFTService): simplified cometBFTService Info #2028
chore(CometBFTService): simplified cometBFTService Info #2028
Changes from all commits
c57f614
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropping this is the main change of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the name here since it's constant. Happy to revert the change if we don't agree with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
LGTM! Consider using iota for initialAppVersion.
The introduction of these constants improves code maintainability and aligns with the PR's simplification objective.
Consider using
iota
forinitialAppVersion
:This would make it easier to introduce new versions in the future if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not seem necessary to make it an attribute of node since it's value won't change upon execution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
CreateQueryContext Still Present in Multiple Files
The
CreateQueryContext
function is still used in the following locations:mod/node-core/pkg/components/api.go
mod/node-api/backend/backend.go
mod/node-api/backend/types.go
mod/node-api/backend/mocks/node.mock.go
mod/consensus/pkg/cometbft/service/abci.go
Please ensure that all instances of
CreateQueryContext
are addressed to fully meet the PR objectives.🔗 Analysis chain
LGTM! Verify elimination of CreateQueryContext.
The change to use a private
appVersion
method simplifies theAppVersion
method and improves code organization.Please confirm that this change eliminates the need for
CreateQueryContext
as mentioned in the PR objectives. Run the following script to verify:Further verification needed: Ensure
CreateQueryContext
is fully eliminated from the codebase.Please run the following script to search for any remaining usage across the repository:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 69
Script:
Length of output: 2203
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows reusing this in
Info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
LGTM! Consider adding error handling.
The new
appVersion
method effectively encapsulates the version retrieval logic, simplifying theAppVersion
method and potentially improving performance.Consider adding error handling for potential issues with
paramStore.Get()
:This would make the function more robust and consistent with Go error handling practices.