Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(withdrawals): Fixed withdrawal for EVM inflation per block #2158
base: main
Are you sure you want to change the base?
feat(withdrawals): Fixed withdrawal for EVM inflation per block #2158
Changes from all commits
d9f823ac0a78e40ad6329fb1177c6c91765270b6aeddb711ed898aefafea1e73c11427ff487e9220f499a2849f227f74cea1cf677fdb51636a3f282File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation for EVM inflation parameters
The validation method should ensure that EVM inflation parameters are properly set since they are critical for the block-by-block inflation mechanism.
Add these validations:
func (c *chainSpec[ DomainTypeT, EpochT, ExecutionAddressT, SlotT, CometBFTConfigT, ]) validate() error { if c.MaxWithdrawalsPerPayload() <= 1 { return ErrInsufficientMaxWithdrawalsPerPayload } + + // Validate EVM inflation parameters + if c.EVMInflationPerBlock() == 0 { + return fmt.Errorf("EVMInflationPerBlock must be greater than 0") + } + + var zeroAddr ExecutionAddressT + if c.EVMInflationAddress() == zeroAddr { + return fmt.Errorf("EVMInflationAddress must not be zero") + } // TODO: Add more validation rules here. return nil }📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rabbit is right, should we at least validate inflation parameters?
ExecutionAddressTits own validationEVMInflationPerBlockever be zero?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance error definition to align with ETH 2.0 spec requirements
The error definition should be more explicit about the valid range and breakdown of withdrawals according to the ETH 2.0 specification.
Consider applying this improvement:
This change:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a note about how these values are set?