Skip to content

Commit

Permalink
refactor(rpc): miss stop PingPongLatencyTimer (backport cometbft#2792) (
Browse files Browse the repository at this point in the history
cometbft#2795)

Closes cometbft#2771


---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request cometbft#2792 done by
[Mergify](https://mergify.com).

Co-authored-by: Khanh Hoa <[email protected]>
  • Loading branch information
mergify[bot] and hoanguyenkh committed Apr 12, 2024
1 parent 575b889 commit e5cf488
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions rpc/jsonrpc/client/ws_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ func (c *WSClient) Stop() error {
}
// only close user-facing channels when we can't write to them
c.wg.Wait()
c.PingPongLatencyTimer.Stop()
close(c.ResponsesCh)

return nil
Expand Down

0 comments on commit e5cf488

Please sign in to comment.