Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs improvements #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion abci/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type Client interface {
Flush(ctx context.Context) error
Echo(ctx context.Context, echo string) (*types.EchoResponse, error)

// FIXME: All other operations are run synchronously and rely
// FIXME: All other operations are run synchronously and rely on
// on the caller to dictate concurrency (i.e. run a go routine),
// with the exception of `CheckTxAsync` which we maintain
// for the v0 mempool. We should explore refactoring the
Expand Down
2 changes: 1 addition & 1 deletion abci/client/mocks/client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion abci/client/socket_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const (
flushThrottleMS = 20 // Don't wait longer than...
)

// socketClient is the client side implementation of the Tendermint
// socketClient is the client-side implementation of the Tendermint
// Socket Protocol (TSP). It is used by an instance of Tendermint to pass
// ABCI requests to an out of process application running the socketServer.
//
Expand Down
2 changes: 1 addition & 1 deletion internal/os/os.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func CopyFile(src, dst string) error {
return errors.New("cannot read from directories")
}

// create new file, truncate if exists and apply same permissions as the original one
// create a new file, truncate if exists and apply same permissions as the original one
dstfile, err := os.OpenFile(dst, os.O_RDWR|os.O_CREATE|os.O_TRUNC, info.Mode().Perm())
if err != nil {
return err
Expand Down
Loading