-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datadog metrics #4
Conversation
…os#18071) Co-authored-by: unknown unknown <unknown@unknown>
…0.0 (cosmos#18123) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…in /x/upgrade (cosmos#18124) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
….13.2 (cosmos#18131) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…734f17 to 0.7.2 (cosmos#18132) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…smos#18152) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…osmos#18154) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…s#18155) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…ode (cosmos#18110) Co-authored-by: Marko <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: cool-developer <[email protected]> Co-authored-by: yihuang <[email protected]>
cosmos#18170) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This reverts commit 52d7b96.
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
WalkthroughThe changes across various files reflect updates to GitHub Actions workflows, with a notable shift from Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 6
Configuration used: CodeRabbit UI
Files ignored due to filter (35)
- api/cosmos/accounts/v1/query_grpc.pb.go
- api/cosmos/accounts/v1/tx_grpc.pb.go
- api/cosmos/counter/v1/query_grpc.pb.go
- api/cosmos/counter/v1/tx_grpc.pb.go
- api/cosmos/feegrant/v1beta1/tx_grpc.pb.go
- api/cosmos/nft/v1beta1/query_grpc.pb.go
- api/cosmos/protocolpool/v1/query_grpc.pb.go
- api/cosmos/protocolpool/v1/tx_grpc.pb.go
- api/cosmos/staking/v1beta1/tx_grpc.pb.go
- api/cosmos/store/streaming/abci/grpc_grpc.pb.go
- api/go.mod
- api/go.sum
- client/docs/swagger-ui/favicon-16x16.png
- client/docs/swagger-ui/favicon-32x32.png
- client/docs/swagger-ui/swagger.yaml
- client/v2/go.mod
- client/v2/go.sum
- collections/go.mod
- collections/go.sum
- core/go.mod
- core/go.sum
- crypto/keys/secp256k1/keys.pb.go
- depinject/go.mod
- depinject/go.sum
- docs/user/run-node/category.json
- errors/go.mod
- errors/go.sum
- go.mod
- go.sum
- log/go.mod
- log/go.sum
- math/go.mod
- math/go.sum
- orm/go.mod
- orm/go.sum
Files selected for processing (53)
- .github/PULL_REQUEST_TEMPLATE.md (2 hunks)
- .github/PULL_REQUEST_TEMPLATE/docs.md (2 hunks)
- .github/dependabot.yml (1 hunks)
- .github/pr_labeler.yml (4 hunks)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/codeql-analysis.yml (1 hunks)
- .github/workflows/dependabot-update-all.yml (1 hunks)
- .github/workflows/dependencies-review.yml (1 hunks)
- .github/workflows/issue_labeler.yml (1 hunks)
- .github/workflows/issues.yml (1 hunks)
- .github/workflows/lint-pr.yml (1 hunks)
- .github/workflows/lint.yml (2 hunks)
- .github/workflows/proto-registry.yml (1 hunks)
- .github/workflows/proto.yml (2 hunks)
- .github/workflows/release-confix.yml (1 hunks)
- .github/workflows/release-cosmovisor.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
- .github/workflows/sims-047.yml (5 hunks)
- .github/workflows/sims-050.yml (5 hunks)
- .github/workflows/sims-nightly.yml (2 hunks)
- .github/workflows/sims.yml (4 hunks)
- .github/workflows/starship-tests.yml (2 hunks)
- .github/workflows/test.yml (50 hunks)
- .golangci.yml (1 hunks)
- CHANGELOG.md (13 hunks)
- CONTRIBUTING.md (1 hunks)
- Dockerfile (1 hunks)
- Makefile (4 hunks)
- README.md (1 hunks)
- RELEASE_PROCESS.md (3 hunks)
- UPGRADING.md (12 hunks)
- api/cosmos/accounts/testing/rotation/v1/partial.pulsar.go (1 hunks)
- api/cosmos/accounts/v1/account_abstraction.pulsar.go (1 hunks)
- api/cosmos/accounts/v1/tx.pulsar.go (5 hunks)
- api/cosmos/auth/module/v1/module.pulsar.go (2 hunks)
- api/cosmos/authz/module/v1/module.pulsar.go (1 hunks)
- api/cosmos/autocli/v1/options.pulsar.go (16 hunks)
- api/cosmos/bank/module/v1/module.pulsar.go (1 hunks)
- api/cosmos/counter/module/v1/module.pulsar.go (1 hunks)
- api/cosmos/counter/v1/query.pulsar.go (1 hunks)
- api/cosmos/counter/v1/tx.pulsar.go (1 hunks)
- api/cosmos/distribution/module/v1/module.pulsar.go (1 hunks)
- api/cosmos/distribution/v1beta1/distribution.pulsar.go (15 hunks)
- api/cosmos/feegrant/v1beta1/tx.pulsar.go (5 hunks)
- api/cosmos/gov/module/v1/module.pulsar.go (14 hunks)
- api/cosmos/gov/v1/gov.pulsar.go (16 hunks)
- api/cosmos/group/module/v1/module.pulsar.go (15 hunks)
- api/cosmos/mint/module/v1/module.pulsar.go (1 hunks)
- api/cosmos/protocolpool/v1/query.pulsar.go (6 hunks)
- api/cosmos/protocolpool/v1/types.pulsar.go (1 hunks)
- api/cosmos/slashing/module/v1/module.pulsar.go (1 hunks)
- api/cosmos/staking/module/v1/module.pulsar.go (2 hunks)
- api/cosmos/staking/v1beta1/staking.pulsar.go (21 hunks)
Files not summarized due to errors (11)
- CHANGELOG.md: Error: Message exceeds token limit
- api/cosmos/accounts/testing/rotation/v1/partial.pulsar.go: Error: Message exceeds token limit
- api/cosmos/accounts/v1/account_abstraction.pulsar.go: Error: Message exceeds token limit
- api/cosmos/accounts/v1/tx.pulsar.go: Error: Message exceeds token limit
- api/cosmos/counter/v1/query.pulsar.go: Error: Message exceeds token limit
- api/cosmos/counter/v1/tx.pulsar.go: Error: Message exceeds token limit
- api/cosmos/distribution/v1beta1/distribution.pulsar.go: Error: Message exceeds token limit
- api/cosmos/feegrant/v1beta1/tx.pulsar.go: Error: Message exceeds token limit
- api/cosmos/protocolpool/v1/query.pulsar.go: Error: Message exceeds token limit
- api/cosmos/protocolpool/v1/types.pulsar.go: Error: Message exceeds token limit
- api/cosmos/staking/v1beta1/staking.pulsar.go: Error: Message exceeds token limit
Files skipped from review due to trivial changes (18)
- .github/PULL_REQUEST_TEMPLATE.md
- .github/PULL_REQUEST_TEMPLATE/docs.md
- .github/dependabot.yml
- .github/pr_labeler.yml
- .github/workflows/dependencies-review.yml
- .github/workflows/issues.yml
- .github/workflows/lint-pr.yml
- .github/workflows/proto-registry.yml
- .github/workflows/proto.yml
- .github/workflows/release-cosmovisor.yml
- .github/workflows/sims-047.yml
- .github/workflows/sims-050.yml
- .github/workflows/sims-nightly.yml
- .github/workflows/sims.yml
- .github/workflows/starship-tests.yml
- .golangci.yml
- CONTRIBUTING.md
- api/cosmos/bank/module/v1/module.pulsar.go
Additional comments: 182
.github/workflows/build.yml (1)
- 24-30: The update to
actions/setup-go@v5
and the specification of Go version1.21
withcheck-latest: true
are correct and follow best practices for ensuring the latest patch version is used..github/workflows/dependabot-update-all.yml (2)
- 18-21: The update to
actions/setup-go@v5
is correctly implemented and should provide the latest features and fixes from the action. Ensure that the specified Go version1.21
is compatible with the rest of the codebase and the dependencies.
The update to
actions/setup-go@v5
with Go version1.21
is consistent with the Go version specified in the majority of thego.mod
files in the codebase.
- 20-21: The
check-latest
flag is set totrue
, which is a good practice for ensuring the latest Go version is used. However, it's important to ensure that the CI pipeline and codebase are prepared to handle any potential breaking changes that could come with newer Go versions..github/workflows/issue_labeler.yml (1)
- 7-13: The update of the
github/issue-labeler
action fromv3.2
tov3.3
is correctly implemented and should bring the benefits of the newer version, such as bug fixes or new features..github/workflows/lint.yml (3)
14-22: The changes to the workflow file correctly introduce the new Nix actions and update the
setup-go
action to version 5.31-50: The introduction of environment variables
NIX
andGIT_DIFF
and the use of Nix for the linting process are correctly implemented in the workflow.31-50: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [14-50]
No issues found with the changes in the workflow file. The updates to the actions and the linting process are consistent with the PR objectives and the summary provided.
.github/workflows/release-confix.yml (1)
- 14-20: The update of the
setup-go
action tov5
is correct and aligns with the PR's objective to update GitHub Actions workflows..github/workflows/test.yml (3)
- 23-23: The summary indicates that the
go-version
parameter values have been updated from"1.21"
to"1.20"
in some places, but the hunks show that thego-version
is consistently"1.21"
. Please verify this discrepancy.Also applies to: 57-57, 91-91, 122-122, 200-200, 230-230, 263-263, 294-294, 325-325, 354-354, 385-385, 416-416, 452-452, 483-483, 514-514, 545-545, 576-576, 609-609, 640-640, 678-678, 709-709, 740-740, 771-771, 802-802, 833-833, 864-864, 895-895, 925-925, 955-955
- 428-431: The summary mentions updates to the
go test
commands where thetags
parameter has been updated to remove therocksdb_build
tag. However, the hunks do not show any such modifications to thego test
commands. Please verify this discrepancy.Also applies to: 723-724, 754-755, 785-786, 816-817, 847-848, 878-879, 909-910, 939-940, 969-970, 999-1000, 1029-1030, 1060-1061, 1091-1092, 1122-1123, 1153-1154, 1184-1185, 1215-1216
- 21-21: The update of the
actions/setup-go
action version fromv4
tov5
is consistent with the summary and is correctly applied across all instances.Also applies to: 55-55, 89-89, 120-120, 198-198, 228-228, 261-261, 292-292, 323-323, 352-352, 383-383, 414-414, 450-450, 481-481, 512-512, 543-543, 574-574, 605-605, 638-638, 676-676, 707-707, 738-738, 769-769, 800-800, 831-831, 862-862, 893-893, 923-923, 953-953
CHANGELOG.md (20)
43-56: The changelog entries under "Features" correctly document new features added to the codebase. Each entry is associated with a pull request, providing traceability.
57-73: The "Improvements" section of the changelog lists various enhancements made across different modules. It is important to ensure that these improvements are reflected in the actual code changes and that the linked pull requests accurately describe the improvements made.
75-87: The "Bug Fixes" section details the fixes applied to various issues in the codebase. Each fix is linked to a pull request, which should contain the actual code changes and discussions around the fix.
89-94: The "API Breaking Changes" section is critical as it documents changes that may affect users of the codebase. It is essential to verify that these breaking changes are communicated clearly to developers and that the linked pull requests provide migration paths or additional context where necessary.
139-144: The entries here continue to document API breaking changes. It is important to ensure that these changes are necessary and that they have been communicated to the users of the library or application.
151-167: This section continues with API breaking changes, which are significant updates that may require users to modify their code. It is crucial to ensure that these changes are justified and that the documentation provides enough information for users to adapt to these changes.
177-179: The changelog entries here document more API breaking changes. It is important to ensure that these changes are communicated clearly and that the linked pull requests provide sufficient information for users to understand and adapt to the changes.
182-186: The "CLI Breaking Changes" section documents changes to the command-line interface, which can significantly impact users who interact with the application through the CLI. It is important to ensure that these changes are necessary and that they are communicated effectively to the users.
189-191: The "State Machine Breaking" section documents changes that affect the state machine's behavior. These are critical changes that can impact the application's core functionality, and it is essential to ensure that they are well-documented and justified.
230-237: The features listed here are significant additions to the codebase. It is important to ensure that they are implemented correctly and that the linked pull requests provide detailed information about the features.
241-251: The improvements listed in this section enhance the existing functionality. It is important to verify that these improvements are reflected in the code and that they align with the project's goals.
257-262: The improvements listed here should be verified against the code changes to ensure they are accurately represented and that the linked pull requests provide the necessary context.
305-307: The "State Machine Breaking" section here documents significant changes to the state machine. It is crucial to ensure that these changes are necessary, correctly implemented, and communicated to the users.
376-377: The removal of methods from the gov keeper and functions from the gov types are significant changes that should be clearly documented and communicated to the users, ensuring they understand how to adapt to these changes.
465-467: The "Client Breaking Changes" section documents changes that affect the client-side of the application. It is important to ensure that these changes are necessary and that they are communicated effectively to the users.
495-497: The CLI command changes listed here are significant and should be verified against the code changes to ensure they are accurately represented and that the linked pull requests provide the necessary context.
502-513: The "Bug Fixes" section documents important fixes to the codebase. It is crucial to ensure that these fixes are correctly implemented and that the linked pull requests provide detailed information about the fixes.
520-525: The bug fixes listed here should be verified against the code changes to ensure they are accurately represented and that the linked pull requests provide the necessary context.
539-541: The deprecation of the
delegator_address
field inMsgCreateValidator
is a significant change that should be clearly documented and communicated to the users, ensuring they understand how to adapt to this change.913-920: The EOL notice for the
v0.46.x
line is important for users to be aware of. It is crucial to ensure that users are informed about the end-of-life status of this version line and that they are encouraged to upgrade to a supported version.Makefile (4)
269-273: The update to the
test-sim-custom-genesis-fast
target correctly changes the genesis file path and adds the-SigverifyTx=false
flag.283-286: The update to the
test-sim-custom-genesis-multi-seed
target correctly changes the genesis file path and adds the-SigverifyTx=false
flag.365-365: The
golangci_version
has been correctly updated tov1.55.0
.410-410: The
CMT_URL
has been correctly updated tohttps://raw.githubusercontent.com/cometbft/cometbft/v0.38.0/proto/tendermint
.README.md (1)
- 37-39: The updated warning message and note about the Go version reflect the changes mentioned in the summary. The language used in the warning message now suggests a less stable state of the Cosmos SDK, and the note emphasizes the necessity of using the latest maintained Go version.
RELEASE_PROCESS.md (4)
- 29-40: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [29-47]
The summary mentions the removal of the
deploy-docs.yml
workflow, but this is not reflected in the provided hunks. Please verify if this change is included elsewhere in the file or in another part of the PR.
85-86: The updates to the support timeline and bugfix-only rule for the 0.47 and 0.50 major releases are correctly reflected in the hunks.
241-247: The clarification regarding the release process for modules that do not depend on the Cosmos SDK, with a specific exception for Store v1, is accurately reflected in the hunks.
32-37: The summary does not mention the modifications made to
test.yml
andbuild.yml
workflows, which are present in the hunks. Please verify if these changes are intended and if they should be documented in the summary.UPGRADING.md (8)
101-107: The changes correctly reflect the deprecation of the
params
module and the introduction of thex/protocolpool
module, as mentioned in the user-provided summary.433-484: The changes to the
TxConfig
interface and the introduction of the newsign_mode_textual
are correctly documented and align with the user-provided summary.61-98: The changes to the module imports, where modules like
auth
,authz
,bank
,distribution
,group
,gov
,mint
,slashing
, andstaking
are now spun out into their owngo.mod
files and imported using thecosmossdk.io
domain, are correctly documented and align with the user-provided summary.800-806: The deprecation of the
params
module is correctly documented, aligning with the user-provided summary.105-107: The introduction of the new
x/protocolpool
module is correctly documented, aligning with the user-provided summary.434-484: The changes to the
TxConfig
interface are correctly documented, aligning with the user-provided summary.436-443: The introduction of the new sign mode is correctly documented, aligning with the user-provided summary.
802-806: The deprecation of the
params
module is correctly documented, aligning with the user-provided summary.api/cosmos/accounts/testing/rotation/v1/partial.pulsar.go (8)
1584-1593: The
MsgInit
struct has a fieldPubKeyBytes
which is exported and contains public key bytes. Ensure that there are no security implications of this field being publicly accessible, especially if it's used in a context where the public key should remain confidential.1656-1657: The
MsgRotatePubKey
struct has a fieldNewPubKeyBytes
which is exported and contains new public key bytes. Similar to theMsgInit
struct, ensure that there are no security implications of this field being publicly accessible.266-290: The
ProtoMethods
function forMsgInit
includes asize
method that calculates the size of the message for marshaling purposes. Ensure that the size calculation accounts for all fields, including any newly added fields in the future, to prevent issues with incomplete message encoding.292-328: The
ProtoMethods
function forMsgInit
includes amarshal
method. Verify that the marshaling process correctly handles all fields, especially if new fields are added in the future, to ensure complete and correct data serialization.330-425: The
ProtoMethods
function forMsgInit
includes anunmarshal
method. It's important to verify that the unmarshaling process correctly handles all fields and that any changes to the message structure are compatible with the expected wire format.1044-1067: The
ProtoMethods
function forMsgRotatePubKey
includes asize
method. As withMsgInit
, ensure that the size calculation is accurate and accounts for all fields to prevent issues with incomplete message encoding.1070-1106: The
ProtoMethods
function forMsgRotatePubKey
includes amarshal
method. Verify that the marshaling process correctly handles all fields and that any changes to the message structure are compatible with the expected wire format.1108-1203: The
ProtoMethods
function forMsgRotatePubKey
includes anunmarshal
method. It's important to verify that the unmarshaling process correctly handles all fields and that any changes to the message structure are compatible with the expected wire format.api/cosmos/accounts/v1/account_abstraction.pulsar.go (29)
1-14: The import block is well-organized and follows Go conventions.
16-65: The
_UserOperation_5_list
and_UserOperation_7_list
types and their methods are correctly implemented to satisfy theprotoreflect.List
interface.130-140: Initialization of global variables in the
init
function is correct and follows Go best practices for setup of protobuf descriptors.143-200: The
fastReflection_UserOperation
type and its methods are correctly implemented to provide efficient reflection-based operations onUserOperation
messages.202-255: The
Range
method implementation forfastReflection_UserOperation
correctly iterates over the fields of theUserOperation
message.258-293: The
Has
method implementation forfastReflection_UserOperation
correctly reports whether a field is populated.295-324: The
Clear
method implementation forfastReflection_UserOperation
correctly clears the fields of theUserOperation
message.327-371: The
Get
method implementation forfastReflection_UserOperation
correctly retrieves the value for a field.373-411: The
Set
method implementation forfastReflection_UserOperation
correctly stores the value for a field.413-455: The
Mutable
method implementation forfastReflection_UserOperation
correctly returns a mutable reference to a composite type.457-486: The
NewField
method implementation forfastReflection_UserOperation
correctly returns a new value that is assignable to the field.488-497: The
WhichOneof
method implementation forfastReflection_UserOperation
correctly reports which field within the oneof is populated.499-515: The
GetUnknown
andSetUnknown
methods forfastReflection_UserOperation
are correctly implemented to handle unknown fields.517-527: The
IsValid
method implementation forfastReflection_UserOperation
correctly reports the validity of the message.529-984: The
ProtoMethods
implementation forfastReflection_UserOperation
provides optional fast reflection-based implementations of various operations.986-1035: The
_UserOperationResponse_3_list
and_UserOperationResponse_5_list
types and their methods are correctly implemented to satisfy theprotoreflect.List
interface.1098-1106: Initialization of global variables in the
init
function is correct and follows Go best practices for setup of protobuf descriptors.1109-1166: The
fastReflection_UserOperationResponse
type and its methods are correctly implemented to provide efficient reflection-based operations onUserOperationResponse
messages.1168-1210: The
Range
method implementation forfastReflection_UserOperationResponse
correctly iterates over the fields of theUserOperationResponse
message.1212-1243: The
Has
method implementation forfastReflection_UserOperationResponse
correctly reports whether a field is populated.1245-1271: The
Clear
method implementation forfastReflection_UserOperationResponse
correctly clears the fields of theUserOperationResponse
message.1273-1311: The
Get
method implementation forfastReflection_UserOperationResponse
correctly retrieves the value for a field.1313-1347: The
Set
method implementation forfastReflection_UserOperationResponse
correctly stores the value for a field.1349-1387: The
Mutable
method implementation forfastReflection_UserOperationResponse
correctly returns a mutable reference to a composite type.1389-1414: The
NewField
method implementation forfastReflection_UserOperationResponse
correctly returns a new value that is assignable to the field.1416-1425: The
WhichOneof
method implementation forfastReflection_UserOperationResponse
correctly reports which field within the oneof is populated.1427-1443: The
GetUnknown
andSetUnknown
methods forfastReflection_UserOperationResponse
are correctly implemented to handle unknown fields.1445-1455: The
IsValid
method implementation forfastReflection_UserOperationResponse
correctly reports the validity of the message.1457-1823: The
ProtoMethods
implementation forfastReflection_UserOperationResponse
provides optional fast reflection-based implementations of various operations.api/cosmos/accounts/v1/tx.pulsar.go (2)
2024-3074: The addition of
MsgExecuteBundle
andMsgExecuteBundleResponse
message types with operations and responses fields respectively, is consistent with the summary provided.3368-3370: The file descriptor variable
File_cosmos_accounts_v1_tx_proto
is part of the generated protobuf code and is used by the protobuf runtime.api/cosmos/auth/module/v1/module.pulsar.go (2)
1302-1305: The byte value at line 1302 has been correctly updated from
0x22, 0xe6, 0x01
to0x22, 0xd6, 0x01
as mentioned in the summary.1314-1317: The byte value at line 1317 has been correctly updated from
0x3a, 0x2b, 0xba, 0xc0, 0x96, 0xda, 0x01, 0x25
to0x3a, 0x1b, 0xba, 0xc0, 0x96, 0xda, 0x01, 0x15
as mentioned in the summary.api/cosmos/authz/module/v1/module.pulsar.go (1)
- 418-425: The changes in this hunk are related to the generated code comments and do not reflect any modifications to byte values or fields within the
Module
struct as mentioned in the summary. This discrepancy should be noted, and the summary should be updated to accurately reflect the changes made in the code.api/cosmos/autocli/v1/options.pulsar.go (5)
1712-1715: The addition of the
GovProposal
field to theRpcCommandOptions
struct is correctly implemented and used within theRange
method.1730-1733: The
FlagOptions
map field inRpcCommandOptions
is correctly defined and used.1734-1734: The
PositionalArgs
field inRpcCommandOptions
is correctly defined and used.1870-1873: The
Skip
field inRpcCommandOptions
is correctly defined and used.1874-1879: The
GovProposal
field inRpcCommandOptions
is correctly defined and used.api/cosmos/counter/module/v1/module.pulsar.go (1)
- 1-579: The summary mentions the addition of new fields to the
Module
message in various packages, includingMaxTitleLen
,MaxSummaryLen
,MaxProposalTitleLen
,MaxProposalSummaryLen
, andMinDepositRatio
. However, these fields are not present in the provided hunk for theModule
struct inapi/cosmos/counter/module/v1/module.pulsar.go
. Please verify if these fields should be included or if the summary is incorrect.api/cosmos/counter/v1/query.pulsar.go (8)
1-1: The file is auto-generated from a protobuf definition and should not be manually edited. Ensure that any changes are made in the corresponding
.proto
files and re-generate this file as needed.788-793: The
QueryGetCountRequest
message type is defined without any fields. Confirm that this is intentional and that no additional data is required for the count query.815-821: The
QueryGetCountResponse
message includes a single fieldTotalCount
. Ensure that this field is sufficient for the response and that no additional information is needed.88-236: The methods
Range
,Has
,Clear
,Get
,Set
,Mutable
,NewField
,WhichOneof
,GetUnknown
,SetUnknown
,IsValid
, andProtoMethods
are auto-generated to fulfill theprotoreflect.Message
interface and should be correct if generated properly.244-368: The
ProtoMethods
method provides custom implementations for marshaling, unmarshaling, and size calculation of the protobuf messages. Ensure that these implementations are correct and efficient.19-22: The
init
function initializes the message descriptors from the protobuf file. Confirm that the protobuf definitions are correct and that the descriptors are being initialized as expected.788-793: The
QueryGetCountRequest
struct includes internal fields for state management, caching, and handling unknown fields. Confirm that these fields are necessary and correctly implemented.815-821: The
QueryGetCountResponse
struct includes an internal field for the total count along with state management, caching, and handling unknown fields. Confirm that these fields are necessary and correctly implemented.api/cosmos/counter/v1/tx.pulsar.go (1)
- 1-1106: The summary does not mention updates to
.go
files generated from.proto
files, yet the provided hunk is from a.go
file that appears to be generated from a.proto
file. Please ensure that the summary accurately reflects all changes made in the PR, including generated files.api/cosmos/distribution/module/v1/module.pulsar.go (1)
- 564-593: The summary mentions alterations to field names and types within the protobuf message definitions, but the hunk provided only shows changes to the protobuf raw descriptor bytes, which are automatically generated and do not typically require manual review. It's important to ensure that any changes to the protobuf definitions are reflected in the corresponding
.proto
files and that they are compatible with any systems that consume these messages.api/cosmos/distribution/v1beta1/distribution.pulsar.go (15)
3706-3767: The implementation of the
_FeePool_2_list
type and its methods appears to be correct and follows the pattern of protobuf list handling in Go. The methods are implemented to manipulate a list ofDecCoin
pointers, which is consistent with protobuf's handling of repeated fields.3841-3846: The check for
len(x.DecimalPool) != 0
before invoking the callback functionf
with thefd_FeePool_decimal_pool
field descriptor and the value of theDecimalPool
list is correct. It ensures that the callback is only called if theDecimalPool
is not empty.3864-3865: The case statement for
"cosmos.distribution.v1beta1.FeePool.decimal_pool"
in the switch correctly checks for the presence of elements in theDecimalPool
field by checking its length.3884-3885: The case statement for
"cosmos.distribution.v1beta1.FeePool.decimal_pool"
correctly sets theDecimalPool
field tonil
, which is a common way to clear a slice in Go.3908-3913: The case statement for
"cosmos.distribution.v1beta1.FeePool.decimal_pool"
correctly handles the case whereDecimalPool
is empty by returning a new instance of_FeePool_2_list
with an empty list. This is consistent with the protobuf pattern for handling repeated fields.3938-3941: The assignment of the
DecimalPool
field from the list value in the case statement for"cosmos.distribution.v1beta1.FeePool.decimal_pool"
is correct. It uses type assertion to convert theprotoreflect.List
to the concrete type_FeePool_2_list
and then assigns the underlying list to theDecimalPool
field.3968-3973: The case statement for
"cosmos.distribution.v1beta1.FeePool.decimal_pool"
correctly initializes theDecimalPool
field if it isnil
before returning aprotoreflect.Value
of the list. This ensures that theDecimalPool
field is always initialized when accessed.3990-3992: The case statement for
"cosmos.distribution.v1beta1.FeePool.decimal_pool"
correctly creates a new list ofDecCoin
and returns aprotoreflect.Value
of the list. This is consistent with the protobuf pattern for handling repeated fields.4068-4073: The loop that iterates over
x.DecimalPool
and calculates the size for serialization is correct. It uses theruntime.Sov
function to compute the size of the varint that represents the length of the encoded message, which is a standard protobuf operation.4103-4117: The loop that marshals the
DecimalPool
field in reverse order for serialization is correct. It checks for errors during marshaling and returns early if an error occurs, which is good error handling practice.4218-4251: The unmarshaling logic for the
DecimalPool
field is correct. It checks the wire type, reads the message length, and handles potential errors such as integer overflow, unexpected EOF, and invalid length. It then appends a newDecCoin
to theDecimalPool
and unmarshals the data into it.7066-7074: The
FeePool
struct has been updated to include theDecimalPool
field, which is a slice ofDecCoin
pointers. The comment indicates that theCommunityPool
field is deprecated and should not be used, which is a good practice for communicating changes in the API.7097-7110: The getter methods for
CommunityPool
andDecimalPool
are implemented correctly. They check fornil
before returning the field value, which prevents potential nil pointer dereferences.7456-7548: The protobuf descriptor changes reflect the addition of the
DecimalPool
field to theFeePool
message. The type names and field numbers are consistent with protobuf's syntax and conventions.7587-7594: The type name references in the
init
function are correct and follow the protobuf pattern for linking message fields to their respective types.api/cosmos/feegrant/v1beta1/tx.pulsar.go (4)
1775-2552: The summary does not mention updates to protobuf definitions, but the provided hunk includes changes to protobuf files. Please ensure the summary accurately reflects all significant changes in the PR.
1775-2552: The addition of
MsgPruneAllowances
andMsgPruneAllowancesResponse
message types introduces new functionality for pruning expired fee allowances. This should be reflected in the summary.2727-2734: The
MsgPruneAllowances
message type correctly includes apruner
field, following the established pattern for message types in this file.2764-2771: The
MsgPruneAllowancesResponse
message type is empty, which is consistent with other response types that do not return data.api/cosmos/gov/module/v1/module.pulsar.go (14)
17-31: The addition of field descriptors for
MaxTitleLen
andMaxSummaryLen
in theinit
function is correct and aligns with the summary.107-121: The
Range
method has been correctly updated to handle the new fieldsMaxTitleLen
andMaxSummaryLen
.138-147: The
Has
method correctly checks for the presence of the new fieldsMaxTitleLen
andMaxSummaryLen
.162-171: The
Clear
method has been updated to clear the new fieldsMaxTitleLen
andMaxSummaryLen
when called.188-199: The
Get
method has been correctly updated to retrieve the values of the new fieldsMaxTitleLen
andMaxSummaryLen
.218-227: The
Set
method has been updated to set the values for the new fieldsMaxTitleLen
andMaxSummaryLen
.246-255: The
Mutable
method correctly panics for the new fieldsMaxTitleLen
andMaxSummaryLen
as they are not mutable composite types.267-276: The
NewField
method has been updated to return a new default value for the new fieldsMaxTitleLen
andMaxSummaryLen
.347-358: The
size
function withinProtoMethods
has been updated to account for the size of the new fieldsMaxTitleLen
andMaxSummaryLen
.382-397: The
marshal
function withinProtoMethods
has been updated to include the new fieldsMaxTitleLen
andMaxSummaryLen
.504-547: The
unmarshal
function withinProtoMethods
has been updated to correctly unmarshal the new fieldsMaxTitleLen
andMaxSummaryLen
.601-610: The
Module
struct has been updated to include the new fieldsMaxTitleLen
andMaxSummaryLen
with appropriate protobuf tags and comments.643-658: Getter methods for the new fields
MaxTitleLen
andMaxSummaryLen
have been added to theModule
struct.665-694: The protobuf file descriptor has been updated to include the new fields
MaxTitleLen
andMaxSummaryLen
in theModule
message.api/cosmos/gov/v1/gov.pulsar.go (15)
5550-5550: The addition of the
MinDepositRatio
field descriptor is consistent with the changes described in the summary.5571-5571: The initialization of the
MinDepositRatio
field descriptor in theinit
function is correct and follows the pattern established by other fields.5729-5734: The conditional check and assignment for
MinDepositRatio
in theRange
method are implemented correctly, following the established pattern for other fields.5780-5781: The
Has
method's case forMinDepositRatio
is correctly checking for a non-empty string, which is the expected behavior for a string field.5828-5829: The
Clear
method's case forMinDepositRatio
correctly sets the field to an empty string, which is the expected behavior for clearing a string field.5897-5899: The
Get
method's case forMinDepositRatio
correctly retrieves the value of the field as aprotoreflect.ValueOfString
.5954-5955: The
Set
method's case forMinDepositRatio
correctly assigns the value to the field, ensuring type safety by asserting the interface to a string.6023-6024: The
Mutable
method's case forMinDepositRatio
correctly panics, as the field is not mutable, which is consistent with the behavior of other non-mutable fields.6073-6074: The
New
method's case forMinDepositRatio
correctly returns a default empty string value, which is the expected behavior for a string field.6205-6208: The size calculation for
MinDepositRatio
in theSize
method is correct, accounting for the length of the string and the size of the varint encoding.6238-6246: The marshaling code for
MinDepositRatio
in theMarshalToSizedBuffer
method is correct, ensuring the string is copied into the buffer and preceded by the appropriate tag and length.6909-6940: The unmarshaling code for
MinDepositRatio
is correct, handling the wire type check, length calculation, and assignment to the field.7728-7733: The comment for
MinDepositRatio
provides a clear explanation of the field's purpose and default behavior, which is helpful for understanding the context of the field.7861-7866: The getter method
GetMinDepositRatio
is implemented correctly, providing a safe way to access theMinDepositRatio
field with a default value if the receiver isnil
.8064-8106: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [8006-8103]
The protobuf field tags and options for
MinDepositRatio
are correctly defined, with the field number, type, and JSON tag all set appropriately.api/cosmos/group/module/v1/module.pulsar.go (13)
17-34: The initialization of field descriptors for the new fields
MaxProposalTitleLen
andMaxProposalSummaryLen
in theModule
struct is correctly implemented.110-125: The
Range
method has been correctly updated to handle the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.141-150: The
Has
method correctly checks for the presence of the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.165-174: The
Clear
method correctly resets the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
to their zero values.191-202: The
Get
method correctly retrieves the values for the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.221-230: The
Set
method correctly assigns values to the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.252-261: The
Mutable
method correctly throws an error when attempting to mutate the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
, as they are not mutable.274-283: The
NewField
method correctly provides a way to create new instances of the fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.354-365: The
ProtoMethods
size function has been correctly updated to account for the size of the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.389-404: The
ProtoMethods
marshal function has been correctly updated to include the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.522-565: The
ProtoMethods
unmarshal function has been correctly updated to parse the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
.617-634: The
Module
struct has been correctly updated with the new fieldsMaxProposalTitleLen
andMaxProposalSummaryLen
, including appropriate protobuf field tags.668-683: Getter methods for the new fields
MaxProposalTitleLen
andMaxProposalSummaryLen
have been correctly implemented in theModule
struct.api/cosmos/mint/module/v1/module.pulsar.go (1)
- 563-587: The summary mentions changes in byte values and string lengths within the variable declaration at line 563, but the hunk provided does not show any changes to variable declarations. It only shows the raw descriptor data for the protobuf file. Please ensure that the summary accurately reflects the changes made in the code.
api/cosmos/protocolpool/v1/query.pulsar.go (6)
871-880: The initialization of
md_QueryUnclaimedBudgetRequest
should be checked to ensure that the message descriptor is correctly retrieved and that the message name matches the expected protobuf message.2170-2178: The
QueryUnclaimedBudgetRequest
message includes anAddress
field. It's important to ensure that this field is properly validated wherever it's used to prevent any security issues related to invalid or malicious addresses.2214-2227: The
QueryUnclaimedBudgetResponse
message includes several fields related to budgeting. It's crucial to ensure that the business logic that populates these fields correctly handles the calculations and time-based operations to prevent any logical errors in budget tracking.2401-2411: The message types and Go types are correctly defined and mapped to the corresponding protobuf messages. This ensures that the generated code will correctly handle the serialization and deserialization of these messages.
2412-2428: The dependency indexes are correctly set up, which ensures that the generated code will have the correct import paths and type references for the protobuf messages.
2485-2494: The
TypeBuilder
is used to construct the file descriptor for the protobuf file. This is part of the generated code and should not be modified manually. It's important to ensure that the generation process is correctly configured to produce the expected output.api/cosmos/protocolpool/v1/types.pulsar.go (2)
1-1: The file is auto-generated by
protoc-gen-go-pulsar
and should not be manually edited.944-969: The
Budget
message type is correctly defined with fields for recipient address, total budget, claimed amount, start time, next claim from, tranches, tranches left, and period.api/cosmos/slashing/module/v1/module.pulsar.go (2)
492-502: The summary mentions alterations to the byte sequence for
module_proto_rawDesc
, but the provided hunk does not show any changes to a byte sequence. Please verify if the summary is accurate or if the relevant changes are not included in the provided hunk.492-502: The changes in the provided hunk are related to comments and package declarations, which typically do not contain substantive changes.
api/cosmos/staking/module/v1/module.pulsar.go (2)
773-777: The summary indicates changes in byte values at line 773 and a longer sequence at line 784, but these changes are not present in the provided hunks. Please verify the accuracy of the summary or the provided hunks.
773-777: The comments in the protobuf file descriptor have been updated, which seems to reflect a change in the structure or content of the
Module
message. Please ensure that these changes are intentional and correctly represent the desired state of the protobuf definitions.api/cosmos/staking/v1beta1/staking.pulsar.go (2)
15947-15948: The addition of the
fee
field toConsPubKeyRotationHistory
should be accompanied by updates to any logic that creates or processes this message to ensure the new field is handled correctly.16006-16014: The new
ValAddrsOfRotatedConsKeys
message should be integrated into the system. Ensure that any logic related to key rotation accounts for this new message and that it is stored and retrieved correctly in the state.
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: "1.21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specified Go version 1.21
does not align with the official Go release versions. Please verify if this is a typo or if a specific versioning system is being used.
@@ -18,7 +18,7 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v4 | |||
- name: Install Go | |||
uses: actions/setup-go@v4 | |||
uses: actions/setup-go@v5 | |||
with: | |||
go-version: "1.21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specified Go version 1.21
is not valid. Go versions follow the pattern 1.x
where x
is a single digit. Please update to a valid Go version, such as 1.21.x
if that was the intended version.
- go-version: "1.21"
+ go-version: "1.21.x" # Replace with the correct version if different
Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
go-version: "1.21" | |
go-version: "1.21.x" # Replace with the correct version if different |
COPY collections/go.mod collections/go.sum ./collections/ | ||
COPY store/go.mod store/go.sum ./store/ | ||
COPY log/go.mod log/go.sum ./log/ | ||
|
||
COPY x/tx/go.mod x/tx/go.sum /x/tx/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a discrepancy in the path for the x/tx
module's go.mod
and go.sum
files. The destination path should be consistent with other modules and have a dot prefix.
- COPY x/tx/go.mod x/tx/go.sum /x/tx/
+ COPY x/tx/go.mod x/tx/go.sum ./x/tx/
Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
COPY x/tx/go.mod x/tx/go.sum /x/tx/ | |
COPY x/tx/go.mod x/tx/go.sum ./x/tx/ |
package accountsv1 | ||
|
||
import ( | ||
_ "cosmossdk.io/api/cosmos/msg/v1" | ||
fmt "fmt" | ||
runtime "github.com/cosmos/cosmos-proto/runtime" | ||
protoreflect "google.golang.org/protobuf/reflect/protoreflect" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of the cosmossdk.io/api/cosmos/msg/v1
package is unused and should be removed to keep the code clean.
- _ "cosmossdk.io/api/cosmos/msg/v1"
Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
package accountsv1 | |
import ( | |
_ "cosmossdk.io/api/cosmos/msg/v1" | |
fmt "fmt" | |
runtime "github.com/cosmos/cosmos-proto/runtime" | |
protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
package accountsv1 | |
import ( | |
fmt "fmt" | |
runtime "github.com/cosmos/cosmos-proto/runtime" | |
protoreflect "google.golang.org/protobuf/reflect/protoreflect" |
import ( | ||
v1beta1 "cosmossdk.io/api/cosmos/base/v1beta1" | ||
fmt "fmt" | ||
_ "github.com/cosmos/cosmos-proto" | ||
runtime "github.com/cosmos/cosmos-proto/runtime" | ||
_ "github.com/cosmos/gogoproto/gogoproto" | ||
_ "google.golang.org/genproto/googleapis/api/annotations" | ||
protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
protoiface "google.golang.org/protobuf/runtime/protoiface" | ||
protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
durationpb "google.golang.org/protobuf/types/known/durationpb" | ||
timestamppb "google.golang.org/protobuf/types/known/timestamppb" | ||
io "io" | ||
reflect "reflect" | ||
sync "sync" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of fmt
is unused and should be removed to keep the code clean and maintainable.
- import (
- ...
- fmt "fmt"
- ...
- )
Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
import ( | |
v1beta1 "cosmossdk.io/api/cosmos/base/v1beta1" | |
fmt "fmt" | |
_ "github.com/cosmos/cosmos-proto" | |
runtime "github.com/cosmos/cosmos-proto/runtime" | |
_ "github.com/cosmos/gogoproto/gogoproto" | |
_ "google.golang.org/genproto/googleapis/api/annotations" | |
protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
protoiface "google.golang.org/protobuf/runtime/protoiface" | |
protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
durationpb "google.golang.org/protobuf/types/known/durationpb" | |
timestamppb "google.golang.org/protobuf/types/known/timestamppb" | |
io "io" | |
reflect "reflect" | |
sync "sync" | |
import ( | |
v1beta1 "cosmossdk.io/api/cosmos/base/v1beta1" | |
_ "github.com/cosmos/cosmos-proto" | |
runtime "github.com/cosmos/cosmos-proto/runtime" | |
_ "github.com/cosmos/gogoproto/gogoproto" | |
_ "google.golang.org/genproto/googleapis/api/annotations" | |
protoreflect "google.golang.org/protobuf/reflect/protoreflect" | |
protoiface "google.golang.org/protobuf/runtime/protoiface" | |
protoimpl "google.golang.org/protobuf/runtime/protoimpl" | |
durationpb "google.golang.org/protobuf/types/known/durationpb" | |
timestamppb "google.golang.org/protobuf/types/known/timestamppb" | |
io "io" | |
reflect "reflect" | |
sync "sync" |
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closing braces for the ProtoMethods
function seem to be missing a comment or annotation that typically accompanies generated code to indicate the end of a method. This is not a functional issue but could be a minor inconsistency in the code generation template.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
Documentation
Chores
/x/auth
directory.Refactor
deploy-docs.yml
workflow to streamline documentation deployment.New Features
Bug Fixes
CONTRIBUTING.md
to ensure proper navigation.Style
Tests
Revert