Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable metrics collecting on eth rpc calls #108

Merged
merged 3 commits into from
Jul 8, 2024
Merged

feat: enable metrics collecting on eth rpc calls #108

merged 3 commits into from
Jul 8, 2024

Conversation

hunter-bera
Copy link
Contributor

@hunter-bera hunter-bera commented Jul 5, 2024 •
edited
Loading

Closes #106

@hunter-bera hunter-bera requested a review from calbera July 5, 2024 21:20
@hunter-bera hunter-bera changed the title enable metrics collecting on eth rpc calls feat: enable metrics collecting on eth rpc calls Jul 5, 2024
@hunter-bera hunter-bera requested a review from jerabera July 5, 2024 21:22
calbera
calbera requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • linter
  • how is it tested? prob worth making the example app use this client, then run it in a local "unit" test
  • link the issue that is being closed here

@hunter-bera hunter-bera requested a review from calbera July 8, 2024 20:56
calbera
calbera reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run make format && make lint for the linter

@hunter-bera hunter-bera requested a review from calbera July 8, 2024 21:29
@hunter-bera hunter-bera added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 221eb3c Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calbera calbera calbera approved these changes

@jerabera jerabera Awaiting requested review from jerabera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics to eth client RPC requests
2 participants
@hunter-bera @calbera