Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi!
First of all syncall is still awesome, I genuinely couldn't work without it as part of my daily flow.
Also apologies for not really being involved since I threw the
caldav
PR at you some time ago!This is a bug I've noticed when using caldav syncall for a while now, but haven't got around to fixing.
Basically tw treats
priority
as a UDA, so can technically be anything, while thecaldav
side expects it to be either L/M/H (the defaults), otherwise it throws an error.As fully supporting UDAs is a massive faff, I've added a simple check that if
priority
is present in the TW side, if it is not in L/M/H, then it will just be set to 0 on the caldav side. Have also included a test case for the new behaviour.Let me know if this needs any further info/testing, and thanks once again!
Fixes # (issue)
N/A
Type of change
not work as expected)
How Has This Been Tested?
Checklist