Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let extract_source = builddir when more than one folders being extracted #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onesuper
Copy link

@onesuper onesuper commented Nov 9, 2015

Hi,

Sometimes, a tar ball does not retain the parent directory. e.g. After type tar -xvf abc.tar.gz , there are some sub directories under the builddir like src, doc... instead of the abc folder.

The original code chooses the latest created folder after extraction to be the working directory for the building stage. I guess it makes more sense if we could return builddir to handle the above case (when more than one folders are extracted).

The new code return Dir.pwd directly, since already the working dir has been changed to builddir. And I make no changes to the tests since the change itself didn't break the test.

Regards
Yichao

@onesuper onesuper changed the title let extract_source to builddir when more than one dirs being extracted let extract_source = builddir when more than one dirs being extracted Nov 9, 2015
@onesuper onesuper changed the title let extract_source = builddir when more than one dirs being extracted let extract_source = builddir when more than one folders being extracted Nov 9, 2015
@onesuper
Copy link
Author

@bernd Not sure whether the change will affect other use case.

@bernd bernd changed the base branch from master to main July 13, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant