Downloads Spinnaker if not found on system #3
Conversation
There was a problem hiding this comment.
I did not see any changes to the C++ code. What's the reason for changing the .clang-format? Are you changes bringing us into compliance with some ROS standard?
There was a problem hiding this comment.
Just added a new commit that uses this .clang-format file to format the code with regards to the ROS C++ style guidelines
There was a problem hiding this comment.
OK, thanks for clarifying. I'm all for following established coding standards.
However, my preference would be to not reformat the code for now. Please revert to the original .clang file and don't reformat the source files. Let's put the cosmetic changes into a separate pull request later. This is considered good practice.
I still owe you a better review on the rest of the PR. I have a lot of open questions regarding how rosdistro works and was trying to work through them with a different driver (event based camera) but it's slow going. Will comment more on the "meat" of your PR.
|
I have folded your commits with the automatic downloading into this repo: |
As seen in flir_camera_driver