Allow turning proxy on and off #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tasks update proxy envs in /etc/environment on each node. Should allow turning proxy on and off
the UpdateNoProxyEnvs has to be called after setup loadbalancers
from now on if regexp doesn't match it adds the line at the end of the /etc/environment
not sufficient, requires same as K8sControlPlaneNodepools in proxy inventory
currentLbs are required to obtain LBs hostnames and add them to noProxyList
…ange tear down and setup LBs gRPC calls contains all LB clusters which are required for noProxyList
this gRPC call handles only change of NO_PROXY and no_proxy envs in kube-proxy and static pods from now on
updates proxy envs in /etc/environment on each k8s nodes. builder calls this as a first gRPC call when starting with ansibler phase
the generated UpdateNoProxyEnvsInK8s was sometimes with capital "s" in generated files
the first time it is build from the nodes in the current state the second time it is build from the desired state because the VPN was installed already
current state isn't change thus there's no need to return it from the gRPC call
instead of passing two seperates strings (httpProxyUrl, noProxyList) pass just one proxyEnvs with both values
move a logic of behind decision to update proxy envs to a separate function DetermineProxyUpdate
Despire
requested changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1526