Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter roles #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Filter roles #2

wants to merge 6 commits into from

Commits on Jul 24, 2022

  1. Improve handling of adding roles to an asset. 

    This allows loading a CSV generated from the Download Spreadsheet link
from the Assets search results pages in RT. It:
 - Handles multiple principals.
 - Strips off the fullname.
 - Handles - ignores - usernames which don't exist (previously Nobody
   account was used).
    @puck
    puck committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    fa86af7 View commit details
    Browse the repository at this point in the history

  2. Move handling of Role fields to a function

    @puck
    puck committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    f679248 View commit details
    Browse the repository at this point in the history

  3. Flesh out managing Roles. 

    This adds:
 - handling groups
 - removing users/groups which aren't in the CSV file
 - handling Owner (with AssetMultipleOwner on and off)
    @puck
    puck committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    92a85c6 View commit details
    Browse the repository at this point in the history

  4. Download Spreadsheet uses 'Catalogue', support that.

    @puck
    puck committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    ec3d2e0 View commit details
    Browse the repository at this point in the history

  5. Fix the selection of the Nobody user. 

    Strictly speaking only the first line needed to be changed, but I figure
for consistency it is clearer if we just use $principal.  ($user and
$principal are pointing to the same object for the second line.)
    @puck
    puck committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    dbcd11e View commit details
    Browse the repository at this point in the history

  6. Support group for signalling a group as well, make space optional. 

    I noticed that RT inserts "group:$group_name" in the role fields when
creating an asset in the web interface.

However, Download Spreadsheet uses "Group: $group_name" (this is what I
initially selected to support).
    @puck
    puck committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    621fec2 View commit details
    Browse the repository at this point in the history