Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: proposed rustfmt settings for the project #477

Merged
merged 17 commits into from
Jan 14, 2024
Merged

RFC: proposed rustfmt settings for the project #477

merged 17 commits into from
Jan 14, 2024

Commits on Jan 7, 2024

  1. RFC: proposed rustfmt settings for the project

    @bunnie
    bunnie committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    d9b26b1 View commit details
    Browse the repository at this point in the history

  2. Remove the exclusions 

    If we harmonize on `rustfmt` for the repo, all exclusions would be removed.
    @bunnie
    bunnie authored Jan 7, 2024
    Configuration menu
    Copy the full SHA
    45edea4 View commit details
    Browse the repository at this point in the history

  3. If PR is accepted, we'd make formatOnSave true by default

    @bunnie
    bunnie authored Jan 7, 2024
    Configuration menu
    Copy the full SHA
    fafee5b View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Update rustfmt.toml 

    absorb feedback on alphabetical ordering
    @bunnie
    bunnie authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    59d65d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Merge branch 'main' into rustfmt-proposal

    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    958517a View commit details
    Browse the repository at this point in the history

  2. cleanup build.yml action 

    I think we don't need to run the full rust toolchain script,
just `rustup update`?

Also update actions version for checkout and comments.
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d510a80 View commit details
    Browse the repository at this point in the history

  3. add a proposed rustfmt check

    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    99a2381 View commit details
    Browse the repository at this point in the history

  4. add a proposed trailing whitespace check

    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    da60e82 View commit details
    Browse the repository at this point in the history

  5. checkout the main rustfmt.toml prior to running CI 

    this is necessary so that patches can't sneak through by
modifying rustfmt.toml to bypass a CI checke.
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ca5845c View commit details
    Browse the repository at this point in the history

  6. cleanup missing -P specifier on grep regex 

    looks like the regex is perl syntax
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5f0e2a4 View commit details
    Browse the repository at this point in the history

  7. have to fetch main before we can checkout the rustfmt.toml

    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6405f91 View commit details
    Browse the repository at this point in the history

  8. fix origin statement 

    sorry this is all pushing to GH directly, the only way i know
how to test this is to push to the branch :P so y'all get
to see me flail.
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    86afec0 View commit details
    Browse the repository at this point in the history

  9. maybe this is the trick? ugh.

    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    62a351f View commit details
    Browse the repository at this point in the history

  10. another try... 

    maybe i'm reading the gh automation error message wrong?
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d14e1b2 View commit details
    Browse the repository at this point in the history

  11. add a formatting document 

    this hopefully helps new users get started with formatting.

didn't want to edit the CONTRIBUTING.md file because it already
has a lot of other stuff in there not specific to formatting.
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    40b4c89 View commit details
    Browse the repository at this point in the history

  12. add trailing whitespace removal to settings 

    also format the file, because, hey guess what...format on save
is on. :P
    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    676bab8 View commit details
    Browse the repository at this point in the history

  13. note new standards in the change log

    @bunnie
    bunnie committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    eb77e76 View commit details
    Browse the repository at this point in the history