setup-node: support NODE_VERSIONS

also only install npm packages if there are npm packages
bevry · Dec 4, 2023 · 0eadb80 · 0eadb80
1 parent 76333dc
commit 0eadb80
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/commands/setup-node b/commands/setup-node
@@ -20,6 +20,7 @@ function setup_node() (
 	# setup.bash provides:
 	local NPM_INSTALL=()
 	local NODE_INSTALL=() # deprecated, use NPM_INSTALL
+	local NODE_VERSIONS=()
 	load_dorothy_config 'setup.bash'
 
 	# deprecations
@@ -135,7 +136,23 @@ function setup_node() (
 	# =====================================
 	# Packages via npm
 
-	setup-util --installer=NODE -- "${NPM_INSTALL[@]}"
+	if test "${#NPM_INSTALL[@]}" -ne 0; then
+		echo-segment --h2='Node.js Packages'
+		setup-util --installer=NODE -- "${NPM_INSTALL[@]}"
+		echo-segment --g2='Node.js Packages'
+	fi
+
+	# =====================================
+	# Additional Node.js versions
+
+	local version
+	if test "${#NODE_VERSIONS[@]}" -ne 0; then
+		echo-segment --h2='Additional Node.js Versions'
+		for version in "${NODE_VERSIONS[@]}"; do
+			nvm-env -- nvm install "$version"
+		done
+		echo-segment --g2='Additional Node.js Versions'
+	fi
 
 	# =====================================
 	# Finish

diff --git a/config/setup.bash b/config/setup.bash
@@ -82,6 +82,7 @@ HOMEBREW_FONTS=(
 # Node.js
 # Used by `setup-node`
 # NPM_INSTALL=()
+# NODE_VERSIONS=()
 
 # Python
 # Used by `setup-python`