Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clippy happy #17

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Sep 19, 2024

Resolves #18 by definition when merged, haha

@alice-i-cecile
Copy link
Member

This time for real: I swear branch protection is set up correctly this time.

@alice-i-cecile
Copy link
Member

Failed sucessfully. TBH, I think you should make an empty lib.rs for now to get this to pass (and maybe remove this dummy test?).

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy is happy, but CI is failing.

@alice-i-cecile
Copy link
Member

You're trying to run DefaultPlugins in your test :)

@janhohenheim
Copy link
Member Author

janhohenheim commented Sep 19, 2024

I thought just disabling WinitPlugin was enough to have it headless 🤔
Let's try RenderPlugin as well.
I tend to avoid MinimalPlugins because it does not play well with glTF loading.

Update: meh, that fails due to missing Shader resources. Let's keep it simple then and use MinimalPlugins.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
* Make clippy happy

* Add semi-empty lib.rs

* Make non-GPU CI happy
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 19, 2024
Merged via the queue into bevyengine:main with commit f767f09 Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI checks aren't being run in the merge queue correctly
2 participants