Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control command capture and replay widget state through UI #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gajop
Copy link
Collaborator

@gajop gajop commented Mar 21, 2023

For capture, also write directly to file so infolog isn't polluted and so it's easier to extract desired commands

@Beherith
Would like some eyes on this - I'm a bit unsure with how to properly initialize these widgets so they're:

  1. actually disabled as desired
  2. don't cause load when disabled
  3. loaded at exactly the right time (after lobby and Configuration are available, but before autologin/connect, which seems to be 1.8s usually - although it's disabled now)

Also it'd be great if you have any pointers on how to have user configuration for options like AUTO_QUIT_ON_FINISH which seem too dangerous even for devs. Always worried I don't accidentally commit it like 153619f ...

For capture, also write directly to file so infolog isn't polluted and so it's easier to extract desired commands
@gajop gajop requested a review from Beherith March 21, 2023 12:17
@FIr3baL
Copy link
Collaborator

FIr3baL commented Jul 11, 2023

@gajop and @Beherith - can we close this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants