Allow friends to join private battle directly #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checkbox, Setting the gatekeeper to friends. Try to directly join, on lobby with a password (could be open for friends)
|
The blocking PR has now been merged and deployed in Teiserver :) |
|
Nice, thank you :) |
|
Testing the branch and this isn't working for me, after checking "Allow friends to join directly" and clicking Host it says a battle is spinning up but never arrives. The following error is in the log: |
|
Got the host to spin up by bringing the changes over to my fork, but this feature isn't working how I'd expect. A password is still being provided but it doesn't work at all, so effectively no one except friends can join. I would expect from the description that this gatekeeper feature would be like giving a fast-pass to friends, rather its just blocking everyone who isn't a friend, even if they have the correct password. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #654
Added a new checkbox in the hostBattleWindow which make it optionally possible to allow friends to join without a password. This checkbox sends a request in the battle lobby to set the gatekeeper to friends.
In PR: beyond-all-reason/teiserver#285
I would like to change the state of the gatekeeper friends to allow friends to join a private battle without entering a password.
Also when trying the to join a private lobby. The user directly tries to connect without a password.
(Users would directly join on reconnect, and as friends to private battles without having to click the join button)