Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2649 (bugs in mex denier gadget) #2650

Closed
wants to merge 1 commit into from

Conversation

A-Lias
Copy link

@A-Lias A-Lias commented Feb 22, 2024

Work done

Fixes a bug in mex denier gadget that prevents a mex build order exactly on top of a metal spot when the "insert command at beginning of queue" hotkey is held (spacebar).

  • Fixes cmdID being overwritten
  • Fixes typo with coordinate variables

Addresses Issue(s)

Issue #2649

Test steps

Issue order to build solar. Then, holding spacebar (or whatever hotkey you have bound to "insert command at beginning of queue"), issue an order to build a mex exactly on a metal spot. It should build without an error or warning.

Issue order to build solar. Then, holding spacebar (or whatever hotkey you have bound to "insert command at beginning of queue"), issue an order to build a mex off of a metal spot (so it snaps to the metal location). It should build on the metal spot without an error or warning.

Issue order to build solar. Then, holding shift (or whatever hotkey you have bound to "insert command at endof queue"), issue an order to build a mex exactly on a metal spot. It should build on the metal spot without an error or warning.

Issue order to build solar. Then, holding shift (or whatever hotkey you have bound to "insert command at endof queue"), issue an order to build a mex off of a metal spot (so it snaps to the metal location). It should build on the metal spot without an error or warning.

@A-Lias A-Lias marked this pull request as ready for review February 22, 2024 20:04
@thehobojoe
Copy link
Contributor

Thank you for this! I unfortunately worked on the same problem before noticing your PR, this one should not only fix the obvious errors I made in mex denier (😬) but also improve meta handling in general. If you're willing to test that would be very helpful #2652

If you are on discord, having another person to help out and discuss these kinds of bugs with would be awesome 🙂

@A-Lias
Copy link
Author

A-Lias commented Feb 23, 2024

Great. I can't test your changes right now, but I'll try to test and get back to you soon.

Closing this PR for now.

@A-Lias A-Lias closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants