Fix https://github.com/beyond-all-reason/spring/issues/1552 #1603
Conversation
| if (groundDecals == &nullDecalDrawer) { | ||
| groundDecals = GetInstance(); | ||
| } | ||
| if (groundDecals != &nullDecalDrawer) |
There was a problem hiding this comment.
Perhaps just SetDecalLevel(decalLevel);?
| @@ -13,6 +13,8 @@ class IGroundDecalDrawer | |||
| CR_DECLARE(IGroundDecalDrawer) | |||
| public: | |||
| static bool GetDrawDecals() { return (decalLevel > 0); } | |||
| static int GetDecalLevel() { return decalLevel; } | |||
There was a problem hiding this comment.
Shouldn't this return std::abs(decalLevel)? Since level +x means x, but -x also means x, just currently disabled.
There was a problem hiding this comment.
When I was going through this I was inclined to remove altogether or just make it binary.
The current approach is inherited that slightly crazy idea of controlling on and off states through the sign bit.
There was a problem hiding this comment.
I was inclined to remove altogether or just make it binary.
Yeah maybe the current "multiplier for decal duration" doesn't make much sense (see also #1476). But some way to control how many decals there can be is good imo (as a performance vs visuals tradeoff knob, since a battlefield littered with scars is cool which is the original reason to extend decal duration).
If not touching the design then perhaps best to just be clean and have separate bool and (u?)int instead of doing bit hax to save 4 bytes. Anyway, current is also fine (since it's just used by the debug print in the /decals command).
No description provided.