Remove uncollidable mines exception #1619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Games can set `blocking = false` in the unit def, or call `Spring.SetUnitBlocking(unitID, nil, false)` in `gadget:UnitCreated`.
sprunk
referenced
this pull request
Jul 24, 2024
…ocked. Masks can now be applied to yardmaps in AddGroundBlockingObject, right now the only masking is that 1 is the opening yard for a factory but that could be extended for future uses later on. (since y is what mines used to be nonblocking can their special case be removed now?) git-svn-id: https://spring.clan-sy.com/svn/spring/trunk@5343 37977431-3df6-0310-b722-df95706aa16b
lhog
reviewed
Nov 2, 2024
| // when not flying) except mines, since their position would | ||
| // be given away otherwise by the PF, etc. | ||
| // NOTE: this does mean that mines can be stacked indefinitely | ||
| // (an extra yardmap character would be needed to prevent this) | ||
| immobile = unitDef->IsImmobileUnit(); |
There was a problem hiding this comment.
Doesn't seem to need this line too.
There was a problem hiding this comment.
Not in this init function, but it sets the member which is used in a bunch of other places, e.g.
spring/rts/Sim/Units/CommandAI/BuilderCAI.cpp
Lines 1680 to 1681 in f9c53c1
Perhaps would be good to refactor those to unit->unitDef->IsImmobileUnit() later but it's not in the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Games can set
blocking = falsein the unit def,or call
Spring.SetUnitBlocking(unitID, nil, false)ingadget:UnitCreated.