Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Buildbot #1666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

12345swordy
Copy link
Contributor

@12345swordy 12345swordy commented Aug 30, 2024

Got approval from ivand regarding this. It didn't effect me building the engine so unless anyone objects this, I am deleting the folder.

Copy link
Collaborator

@sprunk sprunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be two things done in those scripts:

  • produce core engine artifacts (i.e. just run compilation and build the engine). This part is no longer useful and good to remove.
  • do a bunch of release-adjacent tasks. Run some sort of tests (!), upload docs to mediawiki etc. Perhaps people who usually do infra/CI (@p2004a ?) and docs/site (@badosu ?) could look if there is anything useful down there. I expect not really so don't consider it a blocker if they don't respond.

@badosu
Copy link
Collaborator

badosu commented Sep 11, 2024

Docs uses GitHub actions exclusively, if those aren't affected this should be fine (in the scope of docs)

@sprunk
Copy link
Collaborator

sprunk commented Sep 11, 2024

Yes, I mean more like "oh this is solving a nice edge case we haven't thought of". For example it changes C++ std::string to Lua string for weapondef doc which our GitHub actions runner doesn't do.

@p2004a
Copy link
Collaborator

p2004a commented Sep 11, 2024

I looked through it, there is a bunch of interesting stuff, so I will remember it existed: nothing is lost in git history.

@badosu
Copy link
Collaborator

badosu commented Sep 11, 2024

Yes, I mean more like "oh this is solving a nice edge case we haven't thought of". For example it changes C++ std::string to Lua string for weapondef doc which our GitHub actions runner doesn't do.

Interesting, I've never ran buildbot locally so I was unaware of this. Even if it is desirable to have that postprocessing (since it's already there), I don't think the value is good for the complexity. The output format is something that should be processed by the engine itself imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants