-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Buildbot #1666
base: master
Are you sure you want to change the base?
Delete Buildbot #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be two things done in those scripts:
- produce core engine artifacts (i.e. just run compilation and build the engine). This part is no longer useful and good to remove.
- do a bunch of release-adjacent tasks. Run some sort of tests (!), upload docs to mediawiki etc. Perhaps people who usually do infra/CI (@p2004a ?) and docs/site (@badosu ?) could look if there is anything useful down there. I expect not really so don't consider it a blocker if they don't respond.
Docs uses GitHub actions exclusively, if those aren't affected this should be fine (in the scope of docs) |
Yes, I mean more like "oh this is solving a nice edge case we haven't thought of". For example it changes C++ |
I looked through it, there is a bunch of interesting stuff, so I will remember it existed: nothing is lost in git history. |
Interesting, I've never ran buildbot locally so I was unaware of this. Even if it is desirable to have that postprocessing (since it's already there), I don't think the value is good for the complexity. The output format is something that should be processed by the engine itself imo. |
Got approval from ivand regarding this. It didn't effect me building the engine so unless anyone objects this, I am deleting the folder.