Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed namespace from Teiserver to Barserver #212

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Teifion
Copy link
Contributor

@Teifion Teifion commented Jan 28, 2024

Replaces all Teiserver and TeiserverWeb namespaces with Barserver and BarserverWeb. In the future it is possible the project may want to move to make use of the Teiserver library and thus preventing namespace collisions is an important first step. It will also make any integration PRs much easier to review as the find/replace step will have already been completed.

Lowercase teiserver entries cannot be find/replaced as easily since they refer to things like the application name, database tables and certain config key names. They will need to be addressed in a more careful manner.

@Teifion Teifion marked this pull request as ready for review January 28, 2024 11:49
@Teifion
Copy link
Contributor Author

Teifion commented Jan 28, 2024

Unfortunately a number of the tests are failing on my system though swapping back to master the same tests fail. I would highly recommend testing this branch on an integration system before putting it live even though it should not break anything.

@Teifion Teifion assigned Teifion and Beherith and unassigned Teifion Jan 28, 2024
@StanczakDominik StanczakDominik added the needs testing Needs unit tests or testing on integration server label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Needs unit tests or testing on integration server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants