-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed submodule to use @jgarff's rpi_ws281x #86
base: master
Are you sure you want to change the base?
Conversation
Changes look great, thanks a lot. What versions (node / rpi) did you test this on? |
It was tested on RPi 3 Model B+ with NodeJS v8.11.3 |
I don't quite remember what it was, but for some reason I decided to postpone updating to the latest version for our next release. I think it was something incompatible with how things are handled right now, but maybe it was just me not wanting to do the work twice. Did you look through all the changes that were made in upstream? You can already use that new version, see here: #67 (comment)). |
Any reason why this hasn't been merged yet? I forked (and updated/fixed) this for a project I'm working on but it would be great to keep this "main" repository the one to use |
@alberto2000 mainly because of the stated reason. I remember looking through what changed upstream and decided that the update will go into the next major-release. (which you can use right now if you install with |
Hi @usefulthink, thank you for this library. It has already been helpful a few times. We also ran into a problem with this library freezing our raspberry pi and using this PR fixed the problem. Is there a way I can help to get this pull request approved or that I can help to push next to latest? |
@martenbiehl see my earlier comment above. There already is a newer Version (see #67) of this module that should not have this problem. I have no Idea how many people are acutally using that newer version, but as there have been no reports of problems so far, I'm starting to think that I should just retire the old version right now. |
@usefulthink I remember trying the |
Hi @usefulthink, the
on a Raspberry Pi 3B whereas this branch works fine. |
Hello, I replaced the sub-module
rpi_ws281x
with the updated library of @jgarff to avoid making noise sound when RPi uses analog audio speaker output. It works on PIN21 with PCM controller mode.