Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMP-71: Add list staffs API #71

Merged
merged 4 commits into from
Jun 10, 2021
Merged

DMP-71: Add list staffs API #71

merged 4 commits into from
Jun 10, 2021

Conversation

Prnyself
Copy link
Member

Signed-off-by: Prnyself [email protected]

@Prnyself Prnyself changed the title proposal: Add list staffs API DMP-71: Add list staffs API May 24, 2021
@Prnyself
assign dmp number
6f3c5b4 
Signed-off-by: Prnyself <[email protected]>
@Prnyself
Copy link
Member Author

ref: #67

@Xuanwo
Copy link
Contributor

Xuanwo commented May 24, 2021

LGTM

@Prnyself Prnyself marked this pull request as ready for review May 24, 2021 09:58
@Prnyself
Copy link
Member Author

We should consider how to logout a staff, if not, some unavailable staffs are still in DB.
And I will make another proposal to handle this.

@Prnyself Prnyself mentioned this pull request May 25, 2021
Merged
@Xuanwo Xuanwo merged commit 41f7406 into master Jun 10, 2021
@Xuanwo Xuanwo deleted the staff-api-spec branch June 10, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Prnyself @Xuanwo