Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/simple python3 migration #53

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Feature/simple python3 migration #53

wants to merge 33 commits into from

Commits on Jan 20, 2020

  1. updating for python3 and windows compatibility

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6546fa6 View commit details
    Browse the repository at this point in the history

  2. locking down requirements 

    * allowing for a range of dependency versions, locked by api level
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    899587c View commit details
    Browse the repository at this point in the history

  3. adding extras_requires option for installing a viable tensorflow ba… 

    …ckend

* install a viable tensorflow backend by running the command `pip install -e .[tensorflow_backend]`
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    96beec0 View commit details
    Browse the repository at this point in the history

  4. adding notes on how to install a recommended tensorflow backend

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    e4cb4da View commit details
    Browse the repository at this point in the history

  5. fixing csv write error 

    was opening writing as bytes when content to be written was `str`
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    63d1cfc View commit details
    Browse the repository at this point in the history

  6. updating convert_all_datasets.py to opertate with windows 10 and py… 

    …thon 3
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    c8ceac2 View commit details
    Browse the repository at this point in the history

  7. disabling loading of PsychExp dataset 

    * encountering pickle load error: `_pickle.UnpicklingError: the STRING opcode argument must be quoted`
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    3e2feba View commit details
    Browse the repository at this point in the history

  8. coverting to LF from CRLF

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    a628d8a View commit details
    Browse the repository at this point in the history

  9. updating download_weights.py to work in windows10, python3

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    c108abc View commit details
    Browse the repository at this point in the history

  10. fixing imports of example_helper to be used for local invocation

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    079d1f8 View commit details
    Browse the repository at this point in the history

  11. fixup on check_ascii 

    with python3 the values being given to `check_ascii` are now `str` instead of `bytes`

using `word.encode('ascii')` to validate the given word can be ASCII encoded
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    28306cf View commit details
    Browse the repository at this point in the history

  12. removing comment

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    abca333 View commit details
    Browse the repository at this point in the history

  13. minimizing diffs

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    fc0911b View commit details
    Browse the repository at this point in the history

  14. adding smoke tests for scripts in examples/

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    16bdfbd View commit details
    Browse the repository at this point in the history

  15. adding smoke tests for scripts/ 

    fixing docstring
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    47646ca View commit details
    Browse the repository at this point in the history

  16. fixing loading of pickle files

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    177379c View commit details
    Browse the repository at this point in the history

  17. disabling loading of data/PsychExp/raw.pickle 

    obtaining a `_pickle.UnpicklingError: the STRING opcode argument must be quoted`
on loading this file.
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    9047d5b View commit details
    Browse the repository at this point in the history

  18. fixing csv write error 

    was opening writing as `bytes` when content to be written was `str` in python3
    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    dbf55f8 View commit details
    Browse the repository at this point in the history

  19. removing unneeded parenthesis

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    4b21a73 View commit details
    Browse the repository at this point in the history

  20. fixing ascii check for incoming words in shorten_word

    @nklapste
    nklapste committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6da04b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. fixing path for subprocess call

    @nklapste
    nklapste committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    0dc13fc View commit details
    Browse the repository at this point in the history

  2. adding TODO note on failure in test_smoke_create_twitter_vocab

    @nklapste
    nklapste committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    5ff04f2 View commit details
    Browse the repository at this point in the history

  3. adding nose slow attribute to slow smoke tests

    @nklapste
    nklapste committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    81c075c View commit details
    Browse the repository at this point in the history

  4. reordering tests 

    * having analyze result tests `test_smoke_analyze_results` and `test_smoke_analyze_all_results` execute after the `test_smoke_finetune_dataset`
    @nklapste
    nklapste committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    9caaff3 View commit details
    Browse the repository at this point in the history

  5. improving test for test_smoke_download_weights

    @nklapste
    nklapste committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    c2ab3c1 View commit details
    Browse the repository at this point in the history

  6. fixing import of test_helper

    @nklapste
    nklapste committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    8b8fab1 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. adding comments noting the requirement of test execution order for `t… 

    …est_smoke_analyze_results` and `test_smoke_analyze_all_results`
    @nklapste
    nklapste committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    a3480e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Mark tests as slow as they require another slow test

    @bfelbo
    bfelbo committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    22cfee7 View commit details
    Browse the repository at this point in the history

  2. Clarify that twitter dataset is not provided

    @bfelbo
    bfelbo committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    357dd35 View commit details
    Browse the repository at this point in the history

  3. Conver to tf.keras w/o eager mode

    @bfelbo
    bfelbo committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    dc9cbde View commit details
    Browse the repository at this point in the history

  4. Update README on how to not run slow tests

    @bfelbo
    bfelbo committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    bcdb035 View commit details
    Browse the repository at this point in the history

  5. Bump version number as breaks support with Theano

    @bfelbo
    bfelbo committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    269cb43 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Add test for saving/loading model

    @bfelbo
    bfelbo committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    a327694 View commit details
    Browse the repository at this point in the history