Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b2-engine target should build b2 first #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Apr 25, 2023

Also fixes stage/install not installing b2.pdb.

Maybe I misunderstood and it installs bootstraped executable for a good reason?

Also fixes stage/install not installing b2.pdb.
@grafikrobot
Copy link
Member

Maybe I misunderstood and it installs bootstraped executable for a good reason?

There was a reason. I don't remember if it was a good or bad one. I'll need to check the task that generates the Windows installer to see if will break with this change though.

@grafikrobot grafikrobot added the enhancement New feature or request label May 5, 2023
@Kojoley
Copy link
Contributor Author

Kojoley commented May 5, 2023

Maybe I misunderstood and it installs bootstraped executable for a good reason?

There was a reason. I don't remember if it was a good or bad one. I'll need to check the task that generates the Windows installer to see if will break with this change though.

Isn't there a CI task for that? Which is turned off for PRs...

@grafikrobot
Copy link
Member

Maybe I misunderstood and it installs bootstraped executable for a good reason?

There was a reason. I don't remember if it was a good or bad one. I'll need to check the task that generates the Windows installer to see if will break with this change though.

Isn't there a CI task for that? Which is turned off for PRs...

Yes there is :-) It's turned off because I intended to add signing of the installer. But that has turned out to be prohibitively expensive. So perhaps it would be turned back on. And I checked.. And yes the installer will need to change. Although it still has most of the changes needed commented out already.

@grafikrobot
Copy link
Member

Copy link
Member

@grafikrobot grafikrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess the one big question on this is that we want a release build of b2 engine to be installed by default. Which is what the current behavior does.

@Kojoley
Copy link
Contributor Author

Kojoley commented Jun 6, 2023

So I guess the one big question on this is that we want a release build of b2 engine to be installed by default. Which is what the current behavior does.

I'm confused. You want me to add default-build <variant>release?

@grafikrobot
Copy link
Member

I finally realized the real reason I didn't do this originally.. It means setting up a *-config.jam to be able to install. Which would mean having users go through a manual step to install.

@Kojoley
Copy link
Contributor Author

Kojoley commented May 7, 2024

I finally realized the real reason I didn't do this originally.. It means setting up a *-config.jam to be able to install. Which would mean having users go through a manual step to install.

This does not make sense to me. Lets say I have a system installed b2, I call b2 install, I expect it to build and install b2, but it fails because it tries to copy a bootstraped executable when I never wanted to do bootstraping. Other situation: I want to do b2 install toolset=foo lto=on undefined-sanitizer=norecover and copying a bootstraped executable will give me a wrong thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants