Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of sprintf. #328

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Remove use of sprintf. #328

merged 12 commits into from
Aug 28, 2023

Conversation

grafikrobot
Copy link
Member

Proposed changes

Some platforms are now warning on sprintf being unsafe by default. This removes all uses of sprintf for all platforms and replaces them with other built-in methods for conversions or with minimal use of snprintf.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (no functional changes, no api changes)

Further comments

Supersedes #240

Some toolsets are now warning that sprintf is insecure/deprecated. This
replaces all sprintf calls with equivalent b2 equivalents or new prtinf
style utilities. This is for all platforms. Which avoids having to debug
alternate implementations.
Seems clang-cl is broken with latest, 17.7.1, VS release.
VS 2013 doesn't have stdio functions in std namespace.
@grafikrobot grafikrobot merged commit 32d9061 into main Aug 28, 2023
114 of 115 checks passed
@grafikrobot grafikrobot deleted the feature/no-sprintf branch August 28, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant