Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID of Embarcadero C++ Compiler #350

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

FantasqueX
Copy link
Contributor

Currently there is a warning asciidoctor: WARNING: ../../src/tools/embarcadero.jam: line 10: id assigned to section already in use: bbv2.reference.tools.compiler.borland when generating documentation. It seems that ID of Embarcadero C++ Compiler is not set correctly. Since there is no use of this ID, this change should be safe.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Currently there is a warning "asciidoctor: WARNING: ../../src/tools/embarcadero.jam: line 10: id assigned to section already in use: bbv2.reference.tools.compiler.borland" when generating documentation. It seems that ID of Embarcadero C++ Compiler is not set correctly. Since there is no use of this ID, this change should be safe.
@grafikrobot grafikrobot merged commit 5dca296 into bfgroup:main Dec 12, 2023
118 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants